gasket: fix build with kernel >= 6.13 - #384623
Merged
Merged
Conversation
github-actions
Bot
added
10.rebuild-darwin: 0
NixOSInfra
added
the
12.first-time contribution
kylehendricks
approved these changes
Feb 23, 2025
wegank
added
12.approved-by: package-maintainer
drupol
requested changes
Mar 4, 2025
drupol
left a comment
drupol
left a comment
Contributor
There was a problem hiding this comment.
Hello,
Thanks for this first PR against the Nix project, welcome to the nix community !
Here's my feedback:
- Please read the contributing guide to learn how to make a proper commit message. It should look like something:
gasket: fix build with kernel >= 6.13 - Your PR title must match the commit message
Feel free to ping me if you need some help.
FliegendeWurst
marked this pull request as draft
March 23, 2025 10:08
iamruinous
changed the title
iamruinous
force-pushed
the
patch-gasket-driver-kernel-6-13
branch
from
April 15, 2025 04:32
7b48f0a to
6f6a4b7
Compare
iamruinous
marked this pull request as ready for review
April 15, 2025 04:40
eljamm
approved these changes
May 24, 2025
eljamm
left a comment
eljamm
left a comment
Contributor
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review-gha
Command: nixpkgs-review pr 384623
Logs: https://github.com/eljamm/nixpkgs-review-gha/actions/runs/15231866943
x86_64-linux
⏩ 6 packages marked as broken and skipped:
- linuxKernel.packages.linux_5_10.gasket
- linuxKernel.packages.linux_5_10_hardened.gasket
- linuxKernel.packages.linux_5_4.gasket
- linuxKernel.packages.linux_5_4_hardened.gasket
- linuxPackages_5_10_hardened.gasket
- linuxPackages_5_4_hardened.gasket
✅ 18 packages built:
- linuxKernel.packages.linux_5_15.gasket
- linuxPackages_5_15_hardened.gasket (linuxKernel.packages.linux_5_15_hardened.gasket)
- linuxKernel.packages.linux_6_1.gasket
- linuxPackages.gasket (linuxKernel.packages.linux_6_12.gasket)
- linuxPackages_hardened.gasket (linuxPackages_6_12_hardened.gasket)
- linuxKernel.packages.linux_6_13.gasket
- linuxPackages_6_13_hardened.gasket (linuxKernel.packages.linux_6_13_hardened.gasket)
- linuxPackages_latest.gasket (linuxKernel.packages.linux_6_14.gasket)
- linuxPackages_6_1_hardened.gasket (linuxKernel.packages.linux_6_1_hardened.gasket)
- linuxKernel.packages.linux_6_6.gasket
- linuxPackages_6_6_hardened.gasket (linuxKernel.packages.linux_6_6_hardened.gasket)
- linuxPackages_ham.gasket (linuxKernel.packages.linux_ham.gasket)
- linuxPackages_latest-libre.gasket (linuxKernel.packages.linux_latest_libre.gasket)
- linuxPackages-libre.gasket (linuxKernel.packages.linux_libre.gasket)
- linuxPackages_lqx.gasket (linuxKernel.packages.linux_lqx.gasket)
- linuxPackages_xanmod.gasket (linuxKernel.packages.linux_xanmod.gasket)
- linuxPackages_xanmod_latest.gasket (linuxKernel.packages.linux_xanmod_latest.gasket, linuxPackages_xanmod_stable.gasket)
- linuxPackages_zen.gasket (linuxKernel.packages.linux_zen.gasket)
aarch64-linux
⏩ 16 packages marked as broken and skipped:
- linuxKernel.packages.linux_5_10.gasket
- linuxKernel.packages.linux_5_10_hardened.gasket
- linuxKernel.packages.linux_5_4.gasket
- linuxKernel.packages.linux_5_4_hardened.gasket
- linuxKernel.packages.linux_lqx.gasket
- linuxKernel.packages.linux_xanmod.gasket
- linuxKernel.packages.linux_xanmod_latest.gasket
- linuxKernel.packages.linux_xanmod_stable.gasket
- linuxKernel.packages.linux_zen.gasket
- linuxPackages_5_10_hardened.gasket
- linuxPackages_5_4_hardened.gasket
- linuxPackages_lqx.gasket
- linuxPackages_xanmod.gasket
- linuxPackages_xanmod_latest.gasket
- linuxPackages_xanmod_stable.gasket
- linuxPackages_zen.gasket
✅ 14 packages built:
- linuxKernel.packages.linux_5_15.gasket
- linuxPackages_5_15_hardened.gasket (linuxKernel.packages.linux_5_15_hardened.gasket)
- linuxKernel.packages.linux_6_1.gasket
- linuxPackages.gasket (linuxKernel.packages.linux_6_12.gasket)
- linuxPackages_hardened.gasket (linuxPackages_6_12_hardened.gasket)
- linuxKernel.packages.linux_6_13.gasket
- linuxPackages_6_13_hardened.gasket (linuxKernel.packages.linux_6_13_hardened.gasket)
- linuxPackages_latest.gasket (linuxKernel.packages.linux_6_14.gasket)
- linuxPackages_6_1_hardened.gasket (linuxKernel.packages.linux_6_1_hardened.gasket)
- linuxKernel.packages.linux_6_6.gasket
- linuxPackages_6_6_hardened.gasket (linuxKernel.packages.linux_6_6_hardened.gasket)
- linuxPackages_ham.gasket (linuxKernel.packages.linux_ham.gasket)
- linuxPackages_latest-libre.gasket (linuxKernel.packages.linux_latest_libre.gasket)
- linuxPackages-libre.gasket (linuxKernel.packages.linux_libre.gasket)
wegank
added
12.approvals: 2
kylehendricks
approved these changes
Jun 20, 2025
drupol
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add patch to gasket-driver that fixes the build on kernel 6.13
google/gasket-driver#39
google/gasket-driver#40
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.