nginxModules.zstd: 0.1.1 -> 2024-04-22#381037
Conversation
There was a problem hiding this comment.
Should we fetch any of the open PRs https://github.com/tokers/zstd-nginx-module/pulls ?
I think we should fetch tokers/zstd-nginx-module#44 . I am undecided about tokers/zstd-nginx-module#43 as it is bigger. I think we want tokers/zstd-nginx-module#23 to fix home-assistant. tokers/zstd-nginx-module#22 is just tests, I don't think we are even running them.
To apply the patches we need to unpack the source and do some hacks as seen in 99afffd
|
I don't have the time to test other PRs. Upstream seems rather dead. What about removing |
Fixes ordering issue that breaks SSI.
80ae2d3 to
b2415c5
Compare
|
Removed the reference to #359412 since picking the current master only fixes the ordering issue. |
|
Successfully created backport PR for |
|
Followup to remove |
The underlying ordering bug breaks some applications when
services.nginx.recommendedZstdSettingsis enabled, i.e. jitsi-meet because it's using SSI.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.