Skip to content

nginxModules.zstd: 0.1.1 -> 2024-04-22#381037

Merged
fpletz merged 1 commit into
NixOS:masterfrom
fpletz:pkgs/nginx-zstd-module-fix-ordering
Feb 13, 2025
Merged

nginxModules.zstd: 0.1.1 -> 2024-04-22#381037
fpletz merged 1 commit into
NixOS:masterfrom
fpletz:pkgs/nginx-zstd-module-fix-ordering

Conversation

@fpletz

@fpletz fpletz commented Feb 11, 2025

Copy link
Copy Markdown
Member

The underlying ordering bug breaks some applications when services.nginx.recommendedZstdSettings is enabled, i.e. jitsi-meet because it's using SSI.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners Bot requested a review from RaitoBezarius February 11, 2025 01:39
@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 11, 2025

@SuperSandro2000 SuperSandro2000 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we fetch any of the open PRs https://github.com/tokers/zstd-nginx-module/pulls ?

I think we should fetch tokers/zstd-nginx-module#44 . I am undecided about tokers/zstd-nginx-module#43 as it is bigger. I think we want tokers/zstd-nginx-module#23 to fix home-assistant. tokers/zstd-nginx-module#22 is just tests, I don't think we are even running them.

To apply the patches we need to unpack the source and do some hacks as seen in 99afffd

@SuperSandro2000 SuperSandro2000 removed the request for review from RaitoBezarius February 11, 2025 12:11
@fpletz

fpletz commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

I don't have the time to test other PRs. Upstream seems rather dead.

What about removing services.nginx.recommendedZstdSettings instead so people won't use this casually?

Fixes ordering issue that breaks SSI.
@fpletz fpletz force-pushed the pkgs/nginx-zstd-module-fix-ordering branch from 80ae2d3 to b2415c5 Compare February 13, 2025 08:07
@nix-owners nix-owners Bot requested a review from RaitoBezarius February 13, 2025 08:08
@fpletz

fpletz commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

Removed the reference to #359412 since picking the current master only fixes the ordering issue.

@fpletz fpletz merged commit 534fd4b into NixOS:master Feb 13, 2025
@fpletz fpletz deleted the pkgs/nginx-zstd-module-fix-ordering branch February 13, 2025 08:11
@nixpkgs-ci

nixpkgs-ci Bot commented Feb 13, 2025

Copy link
Copy Markdown
Contributor

Successfully created backport PR for release-24.11:

@fpletz

fpletz commented Feb 13, 2025

Copy link
Copy Markdown
Member Author

Followup to remove services.nginx.recommendedZstdSettings: #381678.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants