fix: support S3-compatible services (MinIO) - #14
Open
applearound wants to merge 1 commit into
Open
Conversation
- Add service:'s3' to AwsClient to fix ReadableStream signing - Add S3_PROTOCOL config (default: https) - Add S3_TYPE config for virtual-hosted vs path-style URLs - Read S3_REGION from env (was declared in docker-compose but unused)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deploy Minio for self host s3 service, but is seems unsupportted.
Uploading files to self-hosted S3-compatible services (e.g. MinIO) fails with:
Root cause:
aws4fetchcannot parseserviceandregionfrom non-AWS endpoints (likelocalhost), which causes:X-Amz-Content-Sha256: UNSIGNED-PAYLOADheader (only set whenservice === 's3') is not appliedReadableStreambody fails to sign becauseaws4fetchcan't hash itX-Amz-Credentialin the Authorization header contains wrong service, rejected by MinIOAdditionally,
S3_REGIONwas declared indocker-compose.example.ymlbut never read by the code.No breaking changes for existing AWS S3 users — all new configs have defaults matching current behavior.