fix: read the exported version from package.json - #15
Merged
Conversation
Both packages exported a hand-written `version` literal that a test pinned against the manifest. Changesets bumps the manifest and nothing updated the literal, so the first release failed its own test — and had it passed, a 0.1.0 package would have reported 0.0.0 to anyone who asked. Reading it from package.json makes drift impossible by construction. Rollup tree-shakes the import to the single string: dist/package.js is 114 bytes and the bundle sizes are unchanged. The test stays. It no longer catches drift, but it catches the import breaking, which would leave the export undefined while the manifest keeps its version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013soegYUZNQL5hURYURypVw
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both packages exported a hand-written
versionliteral that a test pinned against the manifest. Changesets bumps the manifest and nothing updated the literal, so the first release failed its own test — and had it passed, a 0.1.0 package would have reported 0.0.0 to anyone who asked.Reading it from package.json makes drift impossible by construction. Rollup tree-shakes the import to the single string: dist/package.js is 114 bytes and the bundle sizes are unchanged.
The test stays. It no longer catches drift, but it catches the import breaking, which would leave the export undefined while the manifest keeps its version.