Network Mapper: Add Docker-based integration testing with CI/CD gates - #11
Merged
Conversation
Implement comprehensive integration testing infrastructure using Docker Compose and Makefile, with automatic execution in CI/CD pipelines before releases. Changes: - Add docker-compose.test.yml with multi-network test environment - 3 test networks (192.168.1.0/24, 10.10.0.0/24, 192.168.0.0/24) - Nginx services for HTTP discovery testing - SSDP/UPnP service for service discovery testing - Healthchecks using curl to ensure services are ready - Dedicated test-runner service with clear output formatting - Enhance Makefile with integration test targets - make test-integration: Full test with automatic cleanup - make test-integration-quick: Fast test without cleanup for debugging - make test-integration-clean: Manual cleanup - make (no args): Shows help menu by default - Integrate tests into CI/CD pipelines - build.yml: Add integration-test job after unit tests - release.yml: Require both unit and integration tests to pass before release - Prevents releases if integration tests fail - Add test-data configuration files - Custom nginx configs for test services - README documenting test environment This ensures all releases are validated against real multi-network scenarios, preventing regressions in network discovery functionality. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
NickBorgers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements comprehensive integration testing infrastructure using Docker Compose and Makefile, with automatic execution in CI/CD pipelines to gate releases.
Changes
🐳 Docker Compose Test Environment
🛠️ Makefile Integration
make test-integration: Full integration test with automatic cleanupmake test-integration-quick: Fast test without cleanup for debuggingmake test-integration-clean: Manual cleanup of containersmake(no args): Shows help menu by default🔒 CI/CD Release Gates
Test Results
✅ Integration test successfully validates:
Motivation
Previously, releases could ship with network discovery regressions because there were no automated end-to-end tests. This PR ensures every release is validated against realistic multi-network scenarios.
Test Plan
make test-integrationpasses🤖 Generated with Claude Code