DO NOT MERGE - add source venv for vm macos test#1
Open
Ni-Langguth wants to merge 5 commits into
Open
Conversation
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 5646296. ♻️ This comment has been updated with latest results. |
During the merge of histograms with automatic axis ranges, the axis range was computed when the fill buffer of the first histogram is full. In this case, this was about halfway during the merge. The resulting histogram was compared to one whose axis range was computed on the full statistics, leading to slightly different axes. By chance, the differences were within the tolerance, but in the commit to follow, the axis range will be extended slightly to make the maximum of a distribution part of the valid range. This will make the test fail. This commit stabilises the test by extending the fill buffer of the first histogram like for all the others in the test. In this way, all axis ranges are computed on the same data.
- When asking THLimitsFinder to optimise axis limits, ask for a maximum slightly right of the actual maximum of the distribution. Otherwise, since the maximum may coincide with the maximum of the axis range, values may fall into the overflow. - Use std::min / std::max to ensure that OptimizeLimits doesn't truncate any values. - For symmetry reasons, also extend the range slightly to lower values. This fixes the problem observed in https://root-forum.cern.ch/t/bug-or-feature-in-ttree-draw/62862 Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
THLimitFinder tries to trim empty bins close to the end of an axis range, but sometimes, the min/max was trimmed as well, so not all data would be visible in the histogram. Here, the case from the following post is tested: https://root-forum.cern.ch/t/bug-or-feature-in-ttree-draw/ Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com> Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
The C++ version flag should be needed on all linux/mac, but it was missing e.g. for RISC-V. To remedy that, the flags is now set by default, and only overridden when needed. See also: https://root-forum.cern.ch/t/no-auxcflags-set-in-root-config-when-building-for-riscv64-6-36-02/64163
…o root-ci in macOS CI to acommodate switch to virtual macOS CI machines
Ni-Langguth
force-pushed
the
Experimental-source-venv-macos-vm
branch
from
September 23, 2025 11:47
1931140 to
5646296
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
This PR fixes #