fix: update search result display logic - #70
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a configuration-based check to prevent loading sponsored search ads when the global "hide sponsored messages" option is enabled, integrating NekoConfig into the dialogs search adapter sponsored query logic. Sequence diagram for hiding sponsored search ads based on NekoConfigsequenceDiagram
actor User
participant DialogsSearchAdapter
participant NekoConfig
participant ConnectionsManager
User->>DialogsSearchAdapter: searchDialogs(text, folderId, allowPublicPosts)
DialogsSearchAdapter->>ConnectionsManager: cancelRequest(sponsoredReqId, true)
DialogsSearchAdapter->>NekoConfig: hideSponsoredMessage.Bool()
alt hideSponsoredMessage.Bool() is true
DialogsSearchAdapter-->DialogsSearchAdapter: sponsoredQuery = null
else hideSponsoredMessage.Bool() is false
DialogsSearchAdapter-->DialogsSearchAdapter: [other conditions on query and premium]
alt conditions fail
DialogsSearchAdapter-->DialogsSearchAdapter: sponsoredQuery = null
else conditions pass
DialogsSearchAdapter-->DialogsSearchAdapter: create TL_contacts_getSponsoredPeers
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The combined condition in the
ifstatement mixes||and&&; consider adding explicit parentheses around the premium/sponsored-disabled clause to make the logic easier to read and less error-prone. - Directly referencing
NekoConfigfromDialogsSearchAdapterincreases coupling; consider routing this configuration through an existing controller or configuration layer instead of importing it directly into the adapter.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The combined condition in the `if` statement mixes `||` and `&&`; consider adding explicit parentheses around the premium/sponsored-disabled clause to make the logic easier to read and less error-prone.
- Directly referencing `NekoConfig` from `DialogsSearchAdapter` increases coupling; consider routing this configuration through an existing controller or configuration layer instead of importing it directly into the adapter.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
omg-xtao
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if hide sponsored messages is enabled it won't hide search ads, this pr would solve it.
Summary by Sourcery
Bug Fixes: