Skip to content

Handle indirect Slack review triggers - #101

Open
DipeshRajoria007 wants to merge 1 commit into
mainfrom
codex/slack-group-mention-intake
Open

Handle indirect Slack review triggers#101
DipeshRajoria007 wants to merge 1 commit into
mainfrom
codex/slack-group-mention-intake

Conversation

@DipeshRajoria007

Copy link
Copy Markdown
Collaborator

Summary

  • register actionable bot_message events instead of dropping them unconditionally
  • detect configured core-dev Slack user-group mentions as indirect triggers
  • preserve a stable actor id for bot-authored Slack events and keep config test fixtures aligned with the current settings schema

Root cause

A Slack post like <!subteam^...> Please review and merge <PR> from Friday was skipped in two places:

  1. intake ignored every bot_message
  2. mention detection only recognized direct bot mentions and owner user mentions, not configured Slack user groups

Testing

  • npm --prefix sidecar run test
  • npm --prefix sidecar run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant