build: migrate simulator to browser Vite SPA - #151
Open
prashant2007-wq wants to merge 1 commit into
Open
Conversation
Closes Newton-School#150. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #150.
Migrates ns-simulator from an Electron app shell to a browser-hosted Vite SPA.
Changes
electron.vite.config.tswith a standardvite.config.ts.src/rendereras the browser app root.vite,vite build, andvite preview.beforeunload.src/main,src/preload, IPC handlers, Electron builder config, and app update config.npm run simulate.Testing
Ran:
npm run typecheck npm run test npm run build npm run lintManual browser verification:
.jsonscenario opening works..jsonscenario saving works.Cmd/Ctrl+Oopens file picker.Cmd/Ctrl+Ssaves the current scenario.dist/.Notes
Safari and Firefox do not support Chromium’s File System Access API, so they use the fallback download/input flows and may re-prompt during save, as expected in the issue scope.
Made with Cursor