Keep comms/ and research/ out of the built package - #235
Open
NewGraphEnvironment wants to merge 1 commit into
Open
Keep comms/ and research/ out of the built package#235NewGraphEnvironment wants to merge 1 commit into
NewGraphEnvironment wants to merge 1 commit into
Conversation
`R CMD build` ships every top-level directory not named in `.Rbuildignore`,
so `pak::pak("NewGraphEnvironment/link")` was putting internal cross-repo
coordination notes and research working files into the installer's library.
`R CMD check` reports this only as a NOTE, and `.gitignore` does not cover it.
Verified against the tarball rather than the config: 37 `comms/` + `research/`
entries before, 0 after.
`planning`, `dev`, `.claude` and `CLAUDE.md` were already excluded - these two
were added later and missed. Convention and an audit loop for the other repos
are in NewGraphEnvironment/soul#60.
Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EPc4Xkk81mE4JHuP5A1SnS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R CMD buildships every top-level directory not named in.Rbuildignore.linkis an installable package, sopak::pak("NewGraphEnvironment/link")was putting internal cross-repo coordination notes (comms/) and research working files (research/) into the installer's library.R CMD checkreports this only as a NOTE, and.gitignoredoes not cover it.Verification
Against the built tarball rather than the config, since the
.Rbuildignoreregex is easy to get subtly wrong:comms/research/Why it was missed
planning,dev,.claudeandCLAUDE.mdwere already excluded.comms/andresearch/were added to the repo later and never added to the ignore list — the gap opens over time rather than at scaffold.This matters for the three-layer repo split:
comms/is internal by definition, so a package that flips public while shipping it leaks exactly what the flip was meant to purge.Notes
Only
.Rbuildignoreis touched. The branch was cut from a working tree with 226 unrelated in-flight changes; none of them are staged or committed here.Convention entry and an audit loop covering the other repos: NewGraphEnvironment/soul#60
🤖 Generated with Claude Code
https://claude.ai/code/session_01EPc4Xkk81mE4JHuP5A1SnS