Skip to content

Unblock CI by fixing lint/import ordering and package metadata compatibility - #4

Merged
dambach merged 2 commits into
mainfrom
copilot/investigate-ci-workflow-fail
Apr 30, 2026
Merged

Unblock CI by fixing lint/import ordering and package metadata compatibility#4
dambach merged 2 commits into
mainfrom
copilot/investigate-ci-workflow-fail

Conversation

Copilot AI commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

CI was failing in the Lint job due to import ordering in tests. Once that was corrected, the packaging path exposed metadata incompatibilities between modern setuptools output and the workflow’s twine check expectations.

  • Lint failure: import ordering in tests

    • Applied isort-compatible import grouping in:
      • tests/test_core.py
      • tests/test_parser.py
    • This aligns local files with the workflow rule isort --check-only --diff --profile black.
  • Build/publish check compatibility

    • Updated packaging metadata in pyproject.toml to avoid generating metadata fields rejected by the current twine check path:
      • constrained build backend to setuptools>=61.0,<77
      • switched license declaration to table form ({ text = "MIT" })
      • removed deprecated license classifier entry

Example of the metadata adjustment:

[build-system]
requires = ["setuptools>=61.0,<77", "wheel"]

[project]
license = { text = "MIT" }
# removed: "License :: OSI Approved :: MIT License"

@dambach
dambach marked this pull request as ready for review April 30, 2026 17:49
Copilot AI review requested due to automatic review settings April 30, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR unblocks the repository’s CI by aligning test import grouping with the isort --profile black check and adjusting packaging metadata/build backend constraints to pass the python -m build + twine check validation used in the workflow.

Changes:

  • Add an isort-compatible blank line separating third-party and first-party imports in tests/test_core.py and tests/test_parser.py.
  • Constrain the build backend requirement to setuptools>=61.0,<77 to avoid CI metadata-check incompatibilities.
  • Update PEP 621 license metadata to license = { text = "MIT" } and remove the MIT license classifier entry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/test_parser.py Adds import-section separation to satisfy isort in CI.
tests/test_core.py Adds import-section separation to satisfy isort in CI.
pyproject.toml Adjusts build-system requirement bounds and modernizes license metadata for twine check compatibility.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dambach
dambach merged commit b7335df into main Apr 30, 2026
15 checks passed
@dambach
dambach deleted the copilot/investigate-ci-workflow-fail branch April 30, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants