Unblock CI by fixing lint/import ordering and package metadata compatibility - #4
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Neures-1158/labchart_txt_parser/sessions/f869c64a-de7c-4b3b-87a5-a74eefe5d065 Co-authored-by: dambach <20612130+dambach@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Neures-1158/labchart_txt_parser/sessions/f869c64a-de7c-4b3b-87a5-a74eefe5d065 Co-authored-by: dambach <20612130+dambach@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dambach
April 30, 2026 17:47
View session
dambach
marked this pull request as ready for review
April 30, 2026 17:49
Contributor
There was a problem hiding this comment.
Pull request overview
This PR unblocks the repository’s CI by aligning test import grouping with the isort --profile black check and adjusting packaging metadata/build backend constraints to pass the python -m build + twine check validation used in the workflow.
Changes:
- Add an
isort-compatible blank line separating third-party and first-party imports intests/test_core.pyandtests/test_parser.py. - Constrain the build backend requirement to
setuptools>=61.0,<77to avoid CI metadata-check incompatibilities. - Update PEP 621 license metadata to
license = { text = "MIT" }and remove the MIT license classifier entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_parser.py | Adds import-section separation to satisfy isort in CI. |
| tests/test_core.py | Adds import-section separation to satisfy isort in CI. |
| pyproject.toml | Adjusts build-system requirement bounds and modernizes license metadata for twine check compatibility. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing in the
Lintjob due to import ordering in tests. Once that was corrected, the packaging path exposed metadata incompatibilities between modern setuptools output and the workflow’stwine checkexpectations.Lint failure: import ordering in tests
isort-compatible import grouping in:tests/test_core.pytests/test_parser.pyisort --check-only --diff --profile black.Build/publish check compatibility
pyproject.tomlto avoid generating metadata fields rejected by the currenttwine checkpath:setuptools>=61.0,<77{ text = "MIT" })Example of the metadata adjustment: