feat(ui): load right panel plugin manifests - #617
Merged
Conversation
This was referenced Jul 20, 2026
Contributor
Author
|
Stack note: this is intentionally based on feat/right-panel-customization so the diff only contains the manifest/lifecycle loader. The repository restrict-non-dev-prs workflow currently blocks non-dev base branches for authors outside ALLOWED_NON_DEV_PR_ACTORS, so CI is skipped until #615 merges and this PR is retargeted to dev, or the allowlist includes this author. |
pascalandr
force-pushed
the
feat/right-panel-plugin-manifest
branch
from
July 25, 2026 10:43
1d1da61 to
a082456
Compare
Contributor
Author
|
Rebased on the updated #615 branch after the right-panel customization popover UX change. Manifest loader diff remains stacked and clean. Validation after rebase:
|
pascalandr
force-pushed
the
feat/right-panel-plugin-manifest
branch
from
July 25, 2026 11:06
a082456 to
a7eee0e
Compare
Contributor
Author
|
Update: rebased this stacked branch on the latest feat/right-panel-customization and force-with-lease pushed a7eee0e.
|
Add a typed manifest loader for right-panel plugins so bundled modules can contribute tabs and Status sections through the registry introduced by the stacked customization PR. The loader runs deterministic onLoad/onUnload lifecycle hooks, skips duplicate or failed manifests without blocking other plugins, and keeps the plugin list explicit for now to avoid arbitrary code loading or marketplace behavior in this step. Validated with focused manifest and registry tests, UI typecheck, whitespace check, UI build, and a final gatekeeper pass.
pascalandr
force-pushed
the
feat/right-panel-plugin-manifest
branch
from
July 28, 2026 11:32
a7eee0e to
6f93f79
Compare
Contributor
Author
|
Update: #617 is now rebased directly on dev after #615 was merged.
|
Route the built-in Git Changes, Files, Status tab definitions and native Status sections through core manifest factories. The render functions still close over the existing RightPanel and StatusTab state, so this proves the manifest contract without widening plugin access to private panel internals or changing user-visible behavior. Validation: npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/plugin-manifest.test.ts; npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/registry.test.ts; npm run typecheck --workspace @codenomad/ui; npm run build --workspace @codenomad/ui; git diff --check.
Contributor
Author
|
Update: pushed e50cf17 to make #617 useful without broadening scope.
|
Derive the native Status tab manifest from CORE_STATUS_SECTION_ITEMS instead of duplicating ids, labels, tooltips, and ordering in core-plugin.tsx. This keeps the customization defaults and plugin manifest source aligned. Missing renderers now fail when building the core manifest so future section additions are caught by the existing manifest test. Validation: npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/plugin-manifest.test.ts; npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/registry.test.ts; npm run typecheck --workspace @codenomad/ui; npm run build --workspace @codenomad/ui; git diff --check
pascalandr
commented
Jul 28, 2026
pascalandr
left a comment
pascalandr
left a comment
Contributor
Author
There was a problem hiding this comment.
Gatekeeper review complete for d74be3e.
Findings: none remaining.
Fixed during review:
- Reused CORE_STATUS_SECTION_ITEMS from the core Status section manifest instead of duplicating section ids, labels, tooltips, and order in core-plugin.tsx. This keeps customization defaults and manifest metadata aligned, and missing renderers now fail in the manifest path.
Validated locally:
- npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/plugin-manifest.test.ts
- npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/registry.test.ts
- npm run typecheck --workspace @codenomad/ui
- npm run build --workspace @codenomad/ui
- git diff --check
Remote checks at review time:
- authorize: pass
- tests-tauri-windows: pass
- restrict-non-dev-prs: skipped as expected for dev base
- tests: still in progress after watcher timeout
- comment artifact job: still in progress
Residual risk: I did not do a manual visual drag/drop pass in the running app; coverage here is code review plus local build/typecheck/tests.
Turn RightPanel.tsx back into the shell for tab chrome, customization, drag ordering, and active manifest rendering. Native Git, Files, and Status wiring now lives in core-runtime.tsx, with Files state and split resizing isolated in focused runtime helpers. This makes the manifest extraction real instead of wrapping a monolith: plugin loading stays in the shell while native tab state is kept behind internal runtime modules, preserving persisted tab, word-wrap, list-open, section-open, and split-width behavior. Validation: npm run typecheck --workspace @codenomad/ui; npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/plugin-manifest.test.ts; npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/registry.test.ts; npm run build --workspace @codenomad/ui; git diff --check
Contributor
Author
|
Follow-up after scope correction:
Validated locally:
Known build note: existing Vite chunk-size warning remains unchanged in nature. |
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/30365369176 Artifacts expire in 7 days.
|
Replace static right panel plugin declarations with first-party manifest factories that receive a small host context for instance, session, i18n, tab activation, tab opening, and future attention reporting. Restore the tab accessibility behavior needed by the Workflows follow-up by wiring tab ids, aria-controls, tab panels, roving tabIndex, and Arrow/Home/End keyboard navigation into the extracted right panel shell. Keep Status as a special always-visible tab, move status section customization into StatusTab itself, and surface module identity plus create failures in the customization UI so bundled modules do not disappear silently. Validated with UI typecheck, targeted right-panel tests, git diff --check, and the UI build. The build still emits the existing large chunk warning.
pascalandr
commented
Jul 31, 2026
pascalandr
left a comment
pascalandr
left a comment
Contributor
Author
There was a problem hiding this comment.
Gatekeeper review: no findings.
I cannot approve this PR through GitHub because it is authored by the same account, but I completed the gatekeeper pass on HEAD 1db1bce.
Checked:
- #618 tab accessibility expectations are preserved: tab ids, aria-controls, tabpanel, roving tabIndex, Arrow/Home/End navigation.
- Manifest API is now a first-party factory with host context for instanceId, t, activeSessionId, isTabActive, openTab, and future attention reporting.
- Panel-mounted lifecycle hooks were removed.
- Status is always visible and status-section customization moved into StatusTab.
- Module identity and create failures are visible in customization instead of disappearing silently.
- Workflows can now be a follow-up bundled module without importing Git/Files/Status internals.
Verified locally:
- npm run typecheck --workspace @codenomad/ui
- npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/plugin-manifest.test.ts
- npm exec --no -- tsx --test packages/ui/src/components/instance/shell/right-panel/registry.test.ts
- npm run build --workspace @codenomad/ui
- git diff --check
Remote checks at review time: authorize and tests passed; tests-tauri-windows and comment were still in progress after waiting.
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/30671004616 Artifacts expire in 7 days.
|
pascalandr
marked this pull request as draft
August 1, 2026 00:14
Remove helper and description copy from the right panel customization surfaces so the popovers only show the controls users need. Move Status section customization behind a compact settings icon in the token counter header, matching the general panel customization affordance while keeping Status itself always available. Validated with UI typecheck, targeted right-panel tests, git diff --check, and the UI build. The build still emits the existing large chunk warning.
pascalandr
marked this pull request as ready for review
August 1, 2026 00:53
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/30676632787 Artifacts expire in 7 days.
|
Collapse tab and Status section customization into one minimal right panel popover. Status remains checked and disabled, with its sections shown directly underneath as indented rows. Remove the separate Status customization trigger and obsolete styling so the panel has one settings affordance and a single reset action at the bottom. Validated with UI typecheck, targeted right-panel tests, git diff --check, and the UI build. The build still emits the existing large chunk warning.
|
PR builds are available as GitHub Actions artifacts: https://github.com/NeuralNomadsAI/CodeNomad/actions/runs/30678480088 Artifacts expire in 7 days.
|
Contributor
Author
|
@shantur LGTM |
pascalandr
added a commit
to pascalandr/CodeNomad
that referenced
this pull request
Aug 3, 2026
Merge upstream/dev at c16cc00 into the workflow host branch. This adopts the first-party right-panel manifest runtime from NeuralNomadsAI#617 and registers Workflows through that contract while preserving stable tab IDs, keyboard navigation, localization, and existing customization behavior. The merge also carries the latest invalid OpenCode configuration diagnostics and retains both workspace lifecycle test paths. Resolutions were validated with server and UI typechecks, the UI production build, the full server suite, focused right-panel/workflow/workspace tests, and an independent regression review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacking
Validation