Repository navigation
C-1: Audit market, factory and treasury contracts after the batch PR merges #1511
Description
Description: PRs #1500, #1501 and #1502 each rewrote overlapping parts of contracts/market, contracts/market_factory, contracts/treasury and contracts/shared. Their merge conflicts were large, and Contracts CI fails on the merged result, so the combined behaviour has not been verified.
Where: contracts/market/src/lib.rs, contracts/market_factory/src/lib.rs, contracts/treasury/src/lib.rs, contracts/shared/src/
Acceptance Criteria:
- Merged contracts compile and all tests pass
- Event emission uses the shared
market_id_to_u64consistently across contracts - Factory to treasury integration and deposit/payout validation reviewed for lost or duplicated checks
- Error code snapshots updated and reviewed
Activity
optimist82 commentedon Oct 21, 2026
@optimist82 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @optimist82 to this issue.
stacyelliott492-star commentedon Oct 21, 2026
@stacyelliott492-star has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @stacyelliott492-star to this issue.
Akinloluwa20 commentedon Oct 21, 2026
@Akinloluwa20 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Akinloluwa20 to this issue.
Ranjeet2063 commentedon Oct 21, 2026
@Ranjeet2063 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Ranjeet2063 to this issue.
mysteriousskater commentedon Oct 21, 2026
@mysteriousskater has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @mysteriousskater to this issue.
iheomadev commentedon Oct 21, 2026
@iheomadev has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @iheomadev to this issue.
drips-wave commentedon Oct 21, 2026
Congratulations, @iheomadev! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @iheomadev: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
drips-wave commentedon Oct 22, 2026
This issue has been completed by @iheomadev as part of the Stellar Wave Program's 10th Wave 🥳
😎 @iheomadev: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.