Dependency-free implementation#1
Open
OpenBagTwo wants to merge 11 commits into
Open
Conversation
Update Minecraft wiki links to new domain
For data version 1343, the 'Blocks' key is needed. In commit cd0133d the code was change to no longer create an AnvilSection if there is no 'BlockStates' key. Change this to also create an AnvilSection if there is a 'Blocks' key.
Update sample world source URL
Fix support for Minecraft version 1.12.2 (data version 1343)
Configure github actions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Netherwhal. First off: thanks for your PR. Your implementation beats the heck out of how I was planning on handling the MUTF8 issue.
I've taken your branch and done three things:
HEADof twoolie's branchmutf8package is installed in the user's environment, that's the version the NBT library will useIf all that meets with your approval, feel free to grab my branch (because I did the rebase, you won't be able to just merge the PR) and update your own PR.
Alternatively, if you'd prefer, I can make a new PR into twoolie's repo myself. Just let me know what you'd prefer.
Validation Performed
mutf8library installed separately into my environmentHere's the script, for reference
With output (excerpted)