Thread byte writes through buffered writers - #126
Draft
fvallenilla wants to merge 1 commit into
Draft
Conversation
fvallenilla
force-pushed
the
pr/writebytes-path
branch
from
March 27, 2026 00:18
01d18a5 to
5ae5154
Compare
Preserve the byte-oriented hot path while keeping buffered string writes allocation-free and making buffer flushes target explicit raw socket sinks, so the writer stack stays fast and the recursion hazard stays covered by tests. Made-with: Cursor
fvallenilla
force-pushed
the
pr/writebytes-path
branch
from
March 27, 2026 02:01
5ae5154 to
f61715e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteBytesWrite(string)withWriteBytes([]byte)behaviorBenchmark results
Baseline: #124
Test plan
go test ./spectator/metergo test ./spectator/writer -run '^$'go test ./spectator/meter -run '^$' -bench 'BenchmarkCounterAddCombined$|BenchmarkCounterAddCombinedPostGC$' -benchmem -count=10go test ./spectator/meter -run '^$' -bench 'BenchmarkWriteLineInt(Current|Bytes)' -benchmem -count=1Made with Cursor