Skip to content

Enable argo hooks to inherit security context from start step #3354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevslinger wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −0
Open

Enable argo hooks to inherit security context from start step #3354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions metaflow/plugins/argo/argo_workflows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3147,6 +3147,13 @@ def _container(cmds):
+ ARGO_WORKFLOWS_KUBERNETES_SECRETS.split(",")
if k
],
security_context=(
kubernetes_sdk.V1SecurityContext(
**resources["security_context"]
)
if resources.get("security_context")
else None
),
resources=kubernetes_sdk.V1ResourceRequirements(
requests={
"cpu": str(kube_defaults["cpu"]),
Expand Down Expand Up @@ -3305,6 +3312,13 @@ def _error_msg_capture_hook_templates(self):
+ ARGO_WORKFLOWS_KUBERNETES_SECRETS.split(",")
if k
],
security_context=(
kubernetes_sdk.V1SecurityContext(
**resources["security_context"]
)
if resources.get("security_context")
else None
),
resources=kubernetes_sdk.V1ResourceRequirements(
# NOTE: base resources for this are kept to a minimum to save on running costs.
# This has an adverse effect on startup time for the daemon, which can be completely
Expand Down Expand Up @@ -3796,6 +3810,13 @@ def _heartbeat_daemon_template(self):
+ ARGO_WORKFLOWS_KUBERNETES_SECRETS.split(",")
if k
],
security_context=(
kubernetes_sdk.V1SecurityContext(
**resources["security_context"]
)
if resources.get("security_context")
else None
),
resources=kubernetes_sdk.V1ResourceRequirements(
# NOTE: base resources for this are kept to a minimum to save on running costs.
# This has an adverse effect on startup time for the daemon, which can be completely
Expand Down