Add @package_sources for sibling source directories - #3351
Merged
Conversation
Contributor
Greptile SummaryThe PR adds a
Confidence Score: 4/5The PR does not appear safe to merge because the previously reported whole-source-root import failure remains unresolved. The default archive mapping still preserves the Files Needing Attention: metaflow/plugins/package_sources.py, test/unit/test_package_sources.py
|
| Filename | Overview |
|---|---|
| metaflow/plugins/package_sources.py | Implements source-spec parsing, archive-path validation, suffix filtering, and package-content generation. |
| metaflow/plugins/init.py | Registers package_sources as a top-level plugin. |
| test/unit/test_package_sources.py | Covers top-level exposure, relative source resolution, archive names, suffixes, validation, and missing sources. |
Reviews (3): Last reviewed commit: "Document package_sources usage" | Re-trigger Greptile
saikonen
previously approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add @package_sources for including sibling or parent source directories in Metaflow code packages.
This supports project layouts where flows and shared application code live in separate directories:
Motivating discussion: https://netflix.slack.com/archives/C02116BBNTU/p1785352517019289
Implementation
Tests