fix: argo 3.7.11 conditional input paths - #3344
Open
saikonen wants to merge 3 commits into
Open
Conversation
saikonen
marked this pull request as ready for review
August 18, 2026 18:35
Contributor
Greptile SummaryThe PR updates Argo conditional execution so skipped branches expose resolvable outputs and downstream tasks include only predecessors that actually ran.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains within the eligible follow-up review scope. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| metaflow/plugins/argo/argo_workflows.py | Introduces conditional Steps wrappers, stable skipped-branch outputs, and revised dependency and input-path generation for newer Argo releases. |
| metaflow/plugins/argo/conditional_input_paths.py | Excludes the explicit /SKIPPED sentinel when selecting executed predecessor pathspecs. |
| test/unit/test_argo_conditional_input_paths.py | Adds focused coverage for skipped sentinels and fallback path selection. |
| test/unit/test_argo_nested_conditional_join.py | Expands regression coverage for nested, sequential, and recursive conditional gating. |
| devtools/Tiltfile | Updates the local Argo chart and controller defaults to exercise Argo Workflows v3.7.11. |
Reviews (3): Last reviewed commit: "fix: exclude foreach joins from wrapped_..." | Re-trigger Greptile
saikonen
force-pushed
the
fix/argo-3.7.11-conditional-input-paths
branch
from
August 21, 2026 21:28
f560ef2 to
920f9fa
Compare
Foreach-join DAGTasks are built via a separate code path in _dag_templates() that never wraps the join node, so including them in the precomputed wrapped_conditional_nodes set caused their container template to be renamed to a cond-* name the DAGTask never references, producing "template name ... undefined" deploy errors. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Summary
Fixes an issue with step input-paths from conditionals not working on argo 3.7.11+/4.0.2+
Issue
Fixes #3043
AI Tool Usage
Claude Code used for test cases and fix iteration