Fix flaky MaestroWorkflowDaoTest properties updates - #240
Merged
Merged
Conversation
praneethy91
reviewed
Aug 26, 2026
| } | ||
|
|
||
| /** | ||
| * maestro_workflow_properties is keyed on (workflow_id, create_time) and the dao takes |
Collaborator
There was a problem hiding this comment.
maestro_workflow_properties is keyed on (workflow_id, create_time) - pretty unfortunate, would have liked if it was a monotonic key instead but I know that's out of scope for this PR
Collaborator
Author
There was a problem hiding this comment.
agreed, the timestamp in the key is the real problem and the sleep only hides it in tests. I'll think more on adding the monotonic version column in a backward compatible way.
praneethy91
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew build --write-locksto refresh dependencies)Changes in this PR
MaestroWorkflowDaoTestfails intermittently withmaestro_workflow_propertiesis keyed on(workflow_id, create_time)andupdateWorkflowPropertiesfillscreate_timefromSystem.currentTimeMillis(), so two updates on the same workflow inside one millisecond collide. Four tests call it repeatedly on one workflow with almost nothing in between, and on a fast machine two of the calls share a millisecond.Those calls now go through a test helper that sleeps a millisecond first. No production change.