netlogo llm extension testing - #9
Conversation
JNK234
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on March 7
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| /Users/jnk789/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/nibor/autolink/autolink/0.6.0/autolink-0.6.0.jar->autolink-0.6.0.jar | ||
| /Users/jnk789/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/com/vladsch/flexmark/flexmark-formatter/0.20.2/flexmark-formatter-0.20.2.jar->flexmark-formatter-0.20.2.jar | ||
| /Users/jnk789/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/piwik/java/tracking/matomo-java-tracker-core/3.4.0/matomo-java-tracker-core-3.4.0.jar->matomo-java-tracker-core-3.4.0.jar | ||
| /Users/jnk789/Library/Caches/Coursier/v1/https/repo1.maven.org/maven2/org/openjfx/javafx-media/21.0.6/javafx-media-21.0.6.jar->javafx-media-21.0.6.jar |
There was a problem hiding this comment.
Platform-specific JavaFX jars accidentally added to bundle
Medium Severity
Two javafx-media jars were added to .bundledFiles, including a Mac ARM64-specific variant (javafx-media-21.0.6-mac-aarch64.jar). JavaFX media is not declared in build.sbt dependencies and is unrelated to LLM text processing. These appear to be transitive dependencies pulled in from the local build environment, and including the mac-aarch64 variant makes the bundle platform-specific.
Additional Locations (1)
1 participant
Added deterministic test cases and automated GitHub workflows
Note
Medium Risk
Adds a new provider-injection mechanism into
LLMExtensionand tweaks template history handling, which could affect runtime behavior if the override is misused; CI/docs changes are low risk.Overview
Adds a deterministic, API-free test layer by introducing a provider factory override in
LLMExtension, a newDeterministicTestProvider, and expanded headless NetLogo language tests intests.txt(covering config, chat/async, choose, templates, and per-agent history isolation).Updates
chat-with-templateto build a copied history when assembling system+user prompts so temporary prompt construction can’t mutate the persistent history.Introduces automation and docs for the new testing approach: a GitHub Actions workflow running
sbt teston pushes/PRs, an optionalpre-pushhook gate (skippable viaSKIP_LOCAL_TESTS), and new/updated testing guidance (docs/TESTING.md,BUILD.md,RELEASE.md, anddemos/tests/README.md).Written by Cursor Bugbot for commit 63e332e. This will update automatically on new commits. Configure here.