PeakMemoryRecorder#1609
Open
dxqb wants to merge 1 commit into
Open
Conversation
…manager Reworks the always-on, import-time-started peak-memory instrumentation into a scoped context manager alongside TorchMemoryRecorder/TorchProfiler in profiling_util.py. Peak RAM is polled on a daemon thread only for the duration of the with-block (Linux via /proc RssAnon, Windows via psutil private bytes); peak VRAM uses CUDA's native counters, reset per block. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
| # psutil's pmem.private is process-private bytes, i.e. Windows' analogue of anon RSS. | ||
| import psutil | ||
| return psutil.Process().memory_info().private | ||
| raise RuntimeError(f"peak RAM tracking not supported on {platform.system()}") |
Contributor
There was a problem hiding this comment.
Will this allow a training to work on Macs? Should we catch this error somewhere?
Collaborator
Author
There was a problem hiding this comment.
I'll merge this disabled, see "enabled=False" above. it's dead code until a dev enables it.
if you think this tool is helpful for you as a dev on Macs feel free to add Mac support, but it's not an issue for a user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sibling to TorchProfiler and TorchMemoryRecorder (which records a memory profile)
disabled by default, only a dev tool
Test plan
pre-commit run --all-filespassesAI assistance