Route console messages through tqdm.write() to avoid corrupted progress bars#1606
Open
dxqb wants to merge 1 commit into
Open
Route console messages through tqdm.write() to avoid corrupted progress bars#1606dxqb wants to merge 1 commit into
dxqb wants to merge 1 commit into
Conversation
…ess bars print() writes to stdout while tqdm's bar redraws go to stderr; the two streams are independently buffered and their writes can interleave at the byte level, corrupting both. Route the messages that can fire while a training-loop, caching, or sampling bar is active through tqdm.write() instead, which synchronizes via tqdm's own lock. Also drop __backup()/__save()'s print_cb parameter: it only ever received either print or step_tqdm.write (itself just a classmethod indistinguishable from the bare tqdm.write, since it doesn't depend on the instance), so both methods can just call tqdm.write() directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
pre-commit run --all-filespassesAI assistance