Skip to content

Document AMD ROCm install for Windows in README#1559

Draft
dxqb wants to merge 1 commit into
Nerogar:masterfrom
dxqb:docs-amd-rocm-windows
Draft

Document AMD ROCm install for Windows in README#1559
dxqb wants to merge 1 commit into
Nerogar:masterfrom
dxqb:docs-amd-rocm-windows

Conversation

@dxqb

@dxqb dxqb commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

Documents AMD ROCm installation in the README. Linux already works out of the box (the installer auto-detects the GPU and installs the ROCm PyTorch build), but the Windows path was undocumented. Windows needs a manual install because the ROCm wheels are architecture-specific and come from AMD's multi-arch index rather than the PyTorch ROCm index.

The Windows steps are consolidated from community testing (thanks to NeuralFault and others). I have not run the Windows install myself, so the procedure still needs confirmation from an AMD/Windows user — hence draft.

Test plan

OneTrainer has no automated test suite. Manual verification is expected.

  • pre-commit run --all-files passes
  • Launched the affected UI or script and exercised the change — N/A, README-only change
  • Tested with at least one real preset / config when relevant — N/A

AI assistance

  • Early AI prototype — opened for discussion, not ready for review

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Comment thread README.md
**Windows:** manual install:

1. Find your GPU's GFX architecture from [AMD's table](https://github.com/ROCm/TheRock/blob/main/RELEASES.md#supported-python-device--install-extras) (e.g. `gfx1100`).
2. Create and activate a venv, then (replace `gfx####`):

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give the commands. not all users know how to do that

@NeuralFault NeuralFault Jun 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be the same procedure as described in the section on LN52-54. Can just refer to Step 1 thru 4 above

@NeuralFault NeuralFault left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just about covers installing on AMD in Windows. Couple things though, the venv creation/activation can just reference the steps given at the beginning of the section to cover on giving the commands to do so.

Also, giving correct full URL path to the bnb whl file, its install command, and 1 (potientially 2) ways to actually set the environment variables as a lot of the less technically inclined users may not know how. Can give example command like I've shown and possibly a blurb about setting a shortcut that sets the variables and launches OT in one go.

Comment thread README.md
@dxqb

dxqb commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator Author

as long as it's not possible to run AMD without setting 5 environment variables, this is too much for the main README
surprising though given that it's AMD themselves. why don't they simplify this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants