Dark mode for Qt6 by TheForgotten69 · Pull Request #1488 · Nerogar/OneTrainer

TheForgotten69 · 2026-05-30T18:44:33Z

Summary

Fix various small issues that occured on Windows:

Remove SetProcessDpiAwareness(1) hack that prevented Qt6 from setting its preferred DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2 context. I've tested this as I have two monitor and didn't got the transparent issue or the UI re-render on the other screen FYI. -> Already in preview now
Replace the forced light-mode workaround with a Windows-scoped apply_theme() that respects the system dark/light
preference. Linux/macOS keep Qt's native theming untouched.
Add theme.py which applies the existing base stylesheet on all platforms and, on Windows only, layers QSS overrides
(QTabWidget::pane / QTabBar contrast fixes + an adaptive progressbar) plus a white text-box fix for light mode — since
Qt's dark mode renders tabs with no contrast on Windows.

The important gist is that the preferred mode is now respected and both light and dark are usable.

Test plan

pre-commit run --all-files passes
Launched the affected UI or script and exercised the change
Tested with at least one real preset / config when relevant (note which: Change is purely UI/Visual so no need for such test here)

AI assistance

AI-assisted — I have read every line in this diff and can defend each change

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

… VideoToolUI Removes abstract _create_browse_dir_button/_create_browse_file_button from BaseVideoToolUIView and uses the combined path_entry component instead, fixing widget alignment issues. Adds allow_video_files flag to path_entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…IView Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…UIView Now handled by path_entry in the base class. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…files) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

@AbstractMethod

Base view concrete methods were accessing self.controller, self.ui_state, and toolkit-specific action methods that were only set by CTK subclass __init__ after the base __init__ call, with no enforcement in the base. - BaseTrainUIView: add controller/ui_state as constructor params; fix sync_cloud_secrets to use controller.train_config; add @AbstractMethod for export_training, generate_debug_package, open_profiling_tool - CtkTrainUIView: reorder __init__ to create deps before base init call; replace self.train_config with self.controller.train_config - BaseCloudTabView: add controller as constructor param - CtkCloudTabView: pass controller to base __init__, drop redundant assignment - BaseCaptionUIView: add ABC + @AbstractMethod for 6 action callbacks - BaseConceptTabView: remove concrete _update_filters() (accessed CTK vars); add ConceptConfig import; add concept: ConceptConfig param to BaseConceptWidgetView.__init__ - CtkConceptTabView: implement _update_filters(); pass concept to base init - BaseConceptWindowView: initialize bucket_ax/text_color/canvas to None - BaseTrainingTabView: replace callbacks dict with 6 @AbstractMethod declarations; restore_optimizer_config(variable: str) matches controller - CtkTrainingTabView: implement all 6 abstract methods directly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The ctypes DPI awareness call is toolkit-specific (fixes CTK transparency on Windows monitor changes). It already exists in CtkTrainUIView.py and has no place in the toolkit-agnostic controller. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- PySide6TrainUIView: create train_config/ui_state/controller before base init so they can be passed as constructor params; replace self.train_config with self.controller.train_config throughout - PySide6CloudTabView: pass controller to BaseCloudTabView.__init__; remove now-redundant self.controller assignment - PySide6ConceptTabView: implement _update_filters() (removed from base); pass concept to BaseConceptWidgetView.__init__ - PySide6TrainingTabView: remove callbacks dict; call build() without it; implement 6 abstract methods with logic inlined from private helpers; remove now-unused private helper methods Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

search_var/filter_var/show_disabled_var were stored in the base but never used there after _update_filters() was removed. Subclasses manage them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…abView Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…d "Text Caching") into preview

…-component) into preview

…nto preview

…o preview

…ng) into preview

…erogar#1476

Qt's dark mode support on Windows is broken (tabs render with no contrast). apply_theme() applies explicit palette and QSS fixes on Windows only, using palette() references so it adapts to the system light/dark preference. Linux/macOS are left to Qt's native handling. Replaces the previous force-light-mode workaround in train_ui_qt.py.

…ight palette

TheForgotten69 · 2026-06-05T21:15:14Z

dark mode is scoped only on window, no custom styles either as the hardcoded white theme is handled

dxqb · 2026-06-07T06:50:14Z

thanks! will mark this waiting and come back to it when the Qt branch has merged

TheForgotten69 · 2026-07-08T21:54:49Z

I saw that Qt is merged in main, any point in me rebasing @dxqb ?
Changes were minimal, scoped only to windows and can be removed down the line

dxqb · 2026-07-11T06:43:50Z

please coordinate this #1593

Zueuk · 2026-07-11T10:29:40Z

@TheForgotten69 what was the Windows problem you were fixing here? Qt Fusion style looks fine on Windows for me in both light and dark modes

Koratahiu and others added 30 commits December 30, 2025 17:04

initial CEP

8b013b0

gamma 1

e4c2521

adjust position

7cd25b8

fix transformer (CEP)

39af0d3

Merge branch 'master' of https://github.com/Nerogar/OneTrainer into cep

df574e0

Merge branch 'upstream' into pr-1235

85a5d38

add flux2

a860bb5

update

67dfd2d

update

230cae8

Merge branch 'upstream' into W16A8

e6fff00

torch 2.11

0c869b8

feat: split CTK UI into controller/base-view/ctk-view pattern

fe50e8d

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: abstract CTK views and migrate logic to controllers

a88f369

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

copy: add PySide6 view copies mirroring CTK structure

f7e4159

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

feat: implement PySide6 views replacing CTK placeholder copies

a36aa74

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'ctk_abstraction' into pyside_copy

c5b21f0

refactor: mirror VideoToolUI path_entry refactor to PySide6VideoToolU…

e19d149

…IView Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: remove _create_browse_dir/file_button from PySide6VideoTool…

624ce5d

…UIView Now handled by path_entry in the base class. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

copy: sync pyside6_components.py with ctk_components.py (allow_video_…

65bdda2

…files) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: add allow_video_files to pyside6_components path_entry

24b1a5e

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'ctk_abstraction' into pyside_copy

307eef2

chore: sync PySide6 copies from ctk_abstraction merge

29a62a1

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

refactor: remove unused __init__ from BaseConceptTabView

1bb5a56

search_var/filter_var/show_disabled_var were stored in the base but never used there after _update_filters() was removed. Subclasses manage them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Merge branch 'ctk_abstraction' into pyside_copy

06ca10c

Merge branch 'pyside_copy' into pyside

98272c8

refactor: move QSizePolicy import to module level in PySide6TrainingT…

a38020a

…abView Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dxqb added 9 commits June 4, 2026 23:36

Merge PR Nerogar#1462 (split "Latent Caching" into "Image Caching" an…

015a312

…d "Text Caching") into preview

Merge PR Nerogar#1476 (Make gradient checkpointing and offloading per…

79c68f5

…-component) into preview

Merge PR Nerogar#1480 (Add AGENTS.md, CLAUDE.md) into preview

878e236

Merge PR Nerogar#1481 (always enable mixed-precision / autocasting) i…

94c0083

…nto preview

Merge PR Nerogar#1487 (Anima) into preview

41024fb

Merge PR Nerogar#1461 (Batch prefetching) into preview

6667a35

Merge PR Nerogar#1498 (Use decorator form for factory.register()) int…

0ffbe0a

…o preview

Merge PR Nerogar#1500 (fix: wire up Ernie text encoder layer offloadi…

1dc2761

…ng) into preview

Remove OffloadingWindow: superseded by per-component offloading from N…

fc363ff

…erogar#1476

dxqb force-pushed the preview branch from 7f4a90b to fc363ff Compare June 4, 2026 21:53

TheForgotten69 added 2 commits June 5, 2026 22:26

Trim theme comment

81dfba6

TheForgotten69 force-pushed the fix/qt6-windows-issues branch from 55b7283 to 81dfba6 Compare June 5, 2026 20:28

TheForgotten69 added 4 commits June 5, 2026 22:30

Keep original light-mode stylesheet, add dark mode separately

3a35ced

Apply Windows dark mode fixes as overrides on top of base stylesheet

feba96b

Preserve forced light mode on non-Windows platforms

d876a93

Simplify theme: drop QSS overrides, fix Windows dark by not forcing l…

eb7be99

…ight palette

dxqb added the waiting waiting for something / cannot fix currently label Jun 7, 2026

dxqb changed the title ~~Fix Qt6 Windows dark mode rendering and DPI warning~~ Dark mode for Qt6 Jun 13, 2026

dxqb force-pushed the preview branch 2 times, most recently from ce63c57 to 3c96784 Compare June 19, 2026 17:00

dxqb changed the base branch from preview to merge July 5, 2026 09:29

dxqb removed the waiting waiting for something / cannot fix currently label Jul 5, 2026

dxqb mentioned this pull request Jul 11, 2026

Custom palette and style sheet for Qt UI light and dark mode, with live update #1593

Open

3 tasks

dxqb changed the base branch from merge to master July 12, 2026 09:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dark mode for Qt6#1488

Dark mode for Qt6#1488
TheForgotten69 wants to merge 110 commits into
Nerogar:masterfrom
TheForgotten69:fix/qt6-windows-issues

TheForgotten69 commented May 30, 2026 •

edited

Loading

Uh oh!

TheForgotten69 commented Jun 5, 2026

Uh oh!

dxqb commented Jun 7, 2026

Uh oh!

TheForgotten69 commented Jul 8, 2026

Uh oh!

dxqb commented Jul 11, 2026

Uh oh!

Zueuk commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

TheForgotten69 commented May 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

AI assistance

Uh oh!

TheForgotten69 commented Jun 5, 2026

Uh oh!

dxqb commented Jun 7, 2026

Uh oh!

TheForgotten69 commented Jul 8, 2026

Uh oh!

dxqb commented Jul 11, 2026

Uh oh!

Zueuk commented Jul 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TheForgotten69 commented May 30, 2026 •

edited

Loading