fix: drop phantom slideMaster overrides & correct jpg MIME (#1444)#2
Merged
Conversation
…1444) Adopts upstream PR gitbrent#1462. In makeXmlContTypes: - Only slideMaster1.xml is ever written, but [Content_Types].xml emitted one <Override> per slide (slideMaster1..N), referencing parts that don't exist. PowerPoint flags the dangling refs and shows the repair dialog on every multi-slide deck. Now emit a single slideMaster1 override. - jpg default content type was the invalid "image/jpg"; corrected to "image/jpeg". Original work by @IgnasStark in gitbrent#1462 (MIT). Co-Authored-By: IgnasStark <IgnasStark@users.noreply.github.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
MBuelowius
force-pushed
the
fix/phantom-slidemaster-1462
branch
from
June 23, 2026 13:44
e1910dc to
c953620
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original author: @IgnasStark — adopted from upstream gitbrent/PptxGenJS#1462 (MIT). Credited via
Co-Authored-Bytrailer.Only
slideMaster1.xmlis ever written, but[Content_Types].xmlemitted one<Override>per slide (slideMaster1..N), referencing parts that do not exist — PowerPoint shows the repair dialog on every multi-slide deck. Now emits a singleslideMaster1override. Also corrects the invalidimage/jpgdefault content type toimage/jpeg.tsc --noEmitclean.dist/not rebuilt here.