Skip to content

Fix quoting for CSV output #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewchi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix quoting for CSV output #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions lib/munin_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import codecs
import traceback
import csv
from lib.munin_vt import VENDORS

CSV_FIELD_ORDER = ['Lookup Hash', 'Rating', 'Comment', 'Positives', 'File Size', 'Virus', 'File Names', 'First Submitted',
Expand Down Expand Up @@ -52,25 +53,30 @@ def writeCSV(info, resultFile):
"""
try:
with codecs.open(resultFile, 'a', encoding='utf8') as fh_results:
# Print every field from the field list to the output file
writer = csv.writer(fh_results, delimiter=';', quotechar='"')
row = []
# Every field from the field list will print to the output file
for field_pretty in CSV_FIELD_ORDER:
field = CSV_FIELDS[field_pretty]
try:
field = info[field]
except KeyError as e:
field = "False"
try:
field = str(field).replace(r'"', r'\"').replace("\n", " ")
field = str(field).replace("\n", " ")
except AttributeError as e:
traceback.print_exc()
fh_results.write("%s;" % field)
row.append(field)
# Append vendor scan results
for vendor in VENDORS:
if vendor in info['vendor_results']:
fh_results.write("%s;" % info['vendor_results'][vendor])
field = info['vendor_results'][vendor]
field = field.replace("\n", " ")
row.append(field)
else:
fh_results.write("-;")
fh_results.write('\n')
row.append("-")
row.append("") # empty final field for backwards compatibility
writer.writerow(row)
except:
traceback.print_exc()
return False
Expand Down