Spinner changes#45
Open
sumateja wants to merge 1 commit into
Open
Conversation
Author
|
Please approve my Pull request |
madhuni
suggested changes
Jul 4, 2020
madhuni
left a comment
madhuni
left a comment
Contributor
There was a problem hiding this comment.
I have provided a couple of comments. Also, your code is not properly formatted. Please run the prettier script before you push the commit to the remote branch.
| } | ||
|
|
||
|
|
||
| const Spinner=(props)=>{ |
Contributor
There was a problem hiding this comment.
Please de-structure your props for better code readability. e.g.
const Spinner = ({type, children}) => {}
| setMarkdown(text) | ||
| }) | ||
|
|
||
| }) |
Contributor
There was a problem hiding this comment.
Why are we not adding anything in the dependencies array? Not providing that in useEffect will lead to serious issues of memory leaks and can cause the performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added Spinner code changes again by taking a new fork