fix: harden command execution, history permissions, and key entry - #104
Merged
Conversation
Addresses five findings from a security review: - TUI -x path executed a *re-queried* AI response instead of the one the user saw and approved, and skipped the dangerous-command warning. Store the displayed Response on the model and execute exactly that, with the isDangerous warning applied. Clear it on errors so a stale command can never run on exit. - The fork-bomb pattern contained unescaped regex metacharacters, so it parsed as alternation and missed whitespace variants. Escaped and made whitespace-tolerant. - Broadened dangerous patterns: rm -fr flag order, bare ~ target, pipe-to-shell (curl | sh), and chmod 777 /. - History file now created 0600 (was 0644) and legacy files tightened on next write; state directory now 0700, matching config-file treatment. - First-run API key entry no longer echoes to the terminal (golang.org/x/term ReadPassword), keeping keys out of scrollback and session recordings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Dependency ReviewThe following issues were found:
License Issuesgo.mod
OpenSSF Scorecard
Scanned Files
|
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses five findings from a security review:
user saw and approved, and skipped the dangerous-command warning.
Store the displayed Response on the model and execute exactly that,
with the isDangerous warning applied. Clear it on errors so a stale
command can never run on exit.
parsed as alternation and missed whitespace variants. Escaped and made
whitespace-tolerant.
pipe-to-shell (curl | sh), and chmod 777 /.
next write; state directory now 0700, matching config-file treatment.
(golang.org/x/term ReadPassword), keeping keys out of scrollback and
session recordings.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com## Description