Skip to content

[WAIT] [infra-557] - Adding space select functionality for position#28

Open
jshcmpbll wants to merge 1 commit into
mainfrom
jc/issue-557
Open

[WAIT] [infra-557] - Adding space select functionality for position#28
jshcmpbll wants to merge 1 commit into
mainfrom
jc/issue-557

Conversation

@jshcmpbll

@jshcmpbll jshcmpbll commented Jan 1, 2023

Copy link
Copy Markdown
Member

Description

Adding the ability to use space to select position

Acceptance Criteria

Tested locally via nix-shell

@jshcmpbll

Copy link
Copy Markdown
Member Author

@sarcasticadmin sarcasticadmin changed the title [REVIEW] [infra-557] - Adding space select functionality for position [READY] [infra-557] - Adding space select functionality for position Jan 4, 2023
@sarcasticadmin

Copy link
Copy Markdown
Contributor

@jshcmpbll cool idea, I like it! But I think it should only work on the checkbox and submit items. Since the name of the user will have a space and that results in it jumping to the Email section.

Additionally something I noticed while testing this locally:

If logged in and selected the following scenario:

> Full Name
> Email

[ ] Senior Software Engineer
[x] Software Engineer

[ Submit ]

Highlight [ Submit ] and press the <spacebar> it will remove your selection for the role resulting in:

> Full Name
> Email

[ ] Senior Software Engineer
[ ] Software Engineer

[ Submit ]


 Resume status: not found 

@sarcasticadmin sarcasticadmin changed the title [READY] [infra-557] - Adding space select functionality for position [WAIT] [infra-557] - Adding space select functionality for position Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants