Repository navigation
An MP4 file its player cannot read tries Firefox's own player first; the load error says how to watch it on the site - #609
Merged
Conversation
…the load error says how to watch it on the site An MP4 file whose player reports an error before anything showed is tried once in Firefox's own player inside FastStream (playDirectly), which reads files mp4box cannot parse and codecs MSE refuses. Not for a refused request (isNetworkFailure), which it would send just the same while the page's new link may be on its way (renewSourceLink), nor once the video has shown a picture. Only then the load error shows; in a page it now ends with the DRM error's own advice: turn FastStream off with its toolbar button to watch the video in the site's own player (player_error_turn_off, that sentence in every locale). FastStream does not step aside by itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…picture (glm's review) "Has this video shown a picture" compared identifiers, and two episodes at the same URL path share one: after the first played, the second never got Firefox's own player. Now that the fallback stays inside FastStream, the test is not needed: a video that showed a picture is rebuilt first (recoverPlayer), and once its rebuilds are used up it plays on in Firefox's own player at the time it was at, instead of the load error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for the user
playDirectlyhand-over, at the time it was at), once the next source and a rebuild are no way out, instead of the load error. FastStream's player and its controls stay; nothing of the page comes back by itself.player_error_turn_off). A player in a tab of its own shows the error alone.What does not change
isNetworkFailure: a range or the first fragment that failed to load) still shows the error: Firefox's own player would send the same request, and the page's new link may be on its way (renewSourceLink, Some recommandations #592).recoverPlayer), as before; only when its rebuilds are used up does Firefox's own player take over, where the load error showed before.Review
glm's review: the first version tried Firefox's own player only before the first picture, by comparing identifiers, which two episodes at the same URL path share - fixed by dropping that test (the rebuild comes first anyway). Its other findings were checked and are not real: Firefox's own player keeps the page's headers since #607 (the review read an outdated fact), and the stall watchdog fires only after a picture (readyState ≥ 2).
Tests
🤖 Generated with Claude Code