ci(release): checkout soap-server + workflow_dispatch to complete 0.1.1 publish - #3
Merged
Merged
Conversation
…space The 0.1.1 release run tagged + GitHub-released onvif-server but failed at `cargo publish`: the `crossref` workspace member has a path-only dep on soap-server (`../../soap-server`), so cargo must read the sibling manifest to assemble the workspace — but release.yml never checked it out (ci.yml does). The old comment wrongly assumed only onvif-server's own (versioned) dep mattered. Mirror ci.yml's soap-server checkout + symlink. Also add a workflow_dispatch trigger (and allow it in the job `if`) so this release — whose tag/GitHub release already exist — can be completed by dispatching the workflow; tag creation and "already uploaded" are both idempotent. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onvif-server 0.1.1 release run created the tag + GitHub release but failed at
cargo publish:The
crossrefworkspace member has a path-only dep on soap-server, so cargo must read the sibling manifest to assemble the workspace.ci.ymlchecks out soap-server for exactly this reason;release.ymlnever did.This PR mirrors ci.yml's soap-server checkout + symlink in release.yml, and adds a
workflow_dispatchtrigger (allowed in the jobif) so the in-flight 0.1.1 publish can be completed by dispatching the workflow — tag creation and "already uploaded" are idempotent.Merging this PR does not trigger a publish (the job
ifrequires a mergedrelease/*PR or workflow_dispatch; this is afix/*branch).