Conversation
The opening-tag path transformed the name before the trailing / was stripped, so the callback got e.g. 'item/', and the self-closing branch transformed it again. Strip the / first and drop the second call.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Goal
Self-closing tags go through
transformTagNametwice: once before the trailing/is stripped, so the callback receives e.g.a/, and again in the self-closing branch. Lowercase or map transforms hide it. With a non-idempotent one they don't:This strips the
/before the single transform call and removes the second call, so each tag is transformed once with its real name. Two side effects of the move:strictReservedNamesnow also rejects<#text/>. Before, it produced{"r":[]}, while<#text></#text>and<#text a="1"/>already threw.allowBooleanAttributes,<a a/>no longer keeps@_a. It only had it because the doubled name madetagName !== tagExp; without a transform it is already dropped. That is a separate bug in the attribute check, not touched here.Added a spec covering paired, empty and attributed self-closing tags.
npm testpasses (333 specs) on Node 22 and 14.Type
Written with AI assistance (Claude); I have reviewed the change.