feat: fix bounding bug on NCweb - #149
Merged
Merged
Conversation
Contributor
Author
|
@matteo-tonini mentioned that the NCWeb PR might be enough to fix it so maybe this is not necessary 🤷♀️ Happy to close otherwise |
|
🎉 This PR is included in version @naturalcycles/js-lib-v15.79.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug on NCWeb where the cntrl shift L bugs out and can not be properly opened and closed. I made a quick fix on NCWeb in this branch: https://github.com/NaturalCycles/NCWeb/pull/4704 but thought I could fix it here...
In dev, React StrictMode runs each effect twice on purpose on mount, cleanup, mount again to catch bugs like this one. Because cleanup couldn't remove the first listener, we ended up with two listeners on the page. I could see that every keypress fired both when console logging one flipped adminMode on, the other immediately flipped it back off, so nothing visibly changed. Production doesn't do this double thing with mount/cleanup, so only one listener was added and worked as expected
Dont know who to tag for this...