fix(ospo): skip self-referential template comparison for archetypes repo - #5
Open
syed-awsaf-informed wants to merge 1 commit into
Open
fix(ospo): skip self-referential template comparison for archetypes repo#5syed-awsaf-informed wants to merge 1 commit into
syed-awsaf-informed wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR updates the OSS checker GitHub Actions workflow to avoid a failing/meaningless “template comparison” when the workflow runs in the archetypes template repository itself.
Changes:
- Skip the archetypes template file comparison when the current repository is the archetypes repo.
- Emit an informational log explaining why the comparison was skipped.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+249
to
+252
| if (context.repo.repo === 'archetypes') { | ||
| record.checks.differsFromTemplate = null; | ||
| core.info(`Skipping template comparison for ${targetPath}: target repository is the archetypes template itself.`); | ||
| } else if (existsSync(archetypePath)) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oss-checker.yml template-comparison check fails when run against the archetypes repo itself, since it checks out archetypes and compares its own files against themselves (always identical). This adds a conditional skip for that specific case.