Check models compatibility in Docker rebuild GH Actions workflow#719
Closed
juhoinkinen wants to merge 14 commits into
Closed
Check models compatibility in Docker rebuild GH Actions workflow#719juhoinkinen wants to merge 14 commits into
juhoinkinen wants to merge 14 commits into
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #719 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 89 89
Lines 6380 6380
=======================================
Hits 6359 6359
Misses 21 21 ☔ View full report in Codecov by Sentry. |
…ackends" This reverts commit 831e5a0.
|
Kudos, SonarCloud Quality Gate passed! |
Member
Author
|
When #762 is merged, the upload/download functionality could be utilized for the models compatibility check. By downloading models (maybe from GitHub Actions cache?) to check this first step could be omitted:
|
Member
Author
|
#907 is a better implementation for the compatibility checking, I close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








The recently added GH Actions workflow for rebuilding Docker images (#715) could also verify that the models trained on the previous image build work (results-wise) identically in the new image. It is quite undesirable that the models would work even slightly differently in different Docker image builds of the same Annif version.
These are the steps in the workflow that aim to verify the compatibility and results identicality of models:
eval.prev.outfile using old imageeval.outfile using new imageeval.prev.outandeval.outwithdiff, and fail the workflow in the case of difference, unless the box for allowing this is checked when triggering the workflowFor both training and evaluation the
tests/corpora/archaeology/fulltext/corpus is used, which is fine for all algorithms I think. Although there could be some dedicated corpora for this.Also, there could be a similar workflow for checking models compatibility when preparing an Annif release, instead of doing compatibility checks manually, so the compatibility-check steps could be moved to a separate action for reusability, like the prepare action of CI/CD workflow.
Note: I've been working on this in my own fork, to avoid accidental image pushes to quay.io.
TODO before merge:
quay.io/natlibfi/anniffromjinkinen/annif