Skip to content

Batch processing in training of NN ensemble - base project suggest calls#676

Draft
juhoinkinen wants to merge 4 commits into
mainfrom
batching-in-nn-ensemble
Draft

Batch processing in training of NN ensemble - base project suggest calls#676
juhoinkinen wants to merge 4 commits into
mainfrom
batching-in-nn-ensemble

Conversation

@juhoinkinen

@juhoinkinen juhoinkinen commented Feb 23, 2023

Copy link
Copy Markdown
Member

This PR experiments with implementing batched suggest calls for the base projects in NN ensemble backend.

Unfortunately there is no notable performance gain in real use, at least with MLLM, fastText, and Omikuji base projects (as in YSO projects of Finto AI), but actually a performance regression. Performance gain is seen when using only Omikuji as the base project, which is the only one of the backends in Finto AI YSO base models having the batch suggest method implemented.

Below results are from for runs at kj-kk using 16 jobs training on corpora/fulltext-train/fi/*/.

MLLM, fastText, and Omikuji base projects

1000 docs, 1 epoch

user time wall time max rss
before (master) 1268.63 2:25.07 14863072
after (PR) 1260.37 2:24.00 14791464

2000 docs, 10 epochs

user time wall time max rss
before (master) 4205.64 4:41.01 15718876
after (PR) 4152.09 4:58.89 15712064

Omikuji base project only

2000 docs, 1 epoch

user time wall time max rss
before (master) 511.38 1:23.13 7827672
after (PR) 336.72 1:13.68 7612384

@codecov

codecov Bot commented Feb 23, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (eb437a8) to head (38c6784).
⚠️ Report is 765 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #676   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          87       87           
  Lines        6157     6164    +7     
=======================================
+ Hits         6131     6138    +7     
  Misses         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented Mar 8, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant