Skip to content

feat(chart): configurable Redis persistence/affinity, rserve probe tuning, LB annotations#80

Open
anchapin wants to merge 1 commit into
179d_spot_instancefrom
feat/chart-redis-rserve-loadbalancer
Open

feat(chart): configurable Redis persistence/affinity, rserve probe tuning, LB annotations#80
anchapin wants to merge 1 commit into
179d_spot_instancefrom
feat/chart-redis-rserve-loadbalancer

Conversation

@anchapin

Copy link
Copy Markdown
Collaborator

Summary

Makes Redis persistence and node affinity optional (toggleable), makes rserve liveness probe parameters configurable, and adds LoadBalancer annotation support.

Changes

redis-deploy.yaml

  • Node affinity block now conditional on redis.affinity.enabled
  • Affinity key/values configurable (redis.affinity.nodegroupKey, nodegroupValues)
  • Allows Redis to schedule on clusters without the web-group node label

redis-pvc.yaml

  • PVC gated by redis.persistence.enabled
  • Volume in deploy.yaml switches to emptyDir when persistence.enabled: false
  • Useful for ephemeral/dev deployments or when Redis data is disposable

rserve-deploy.yaml

  • Liveness probe now fully configurable:
    rserve.livenessProbe.initialDelaySeconds/periodSeconds/timeoutSeconds/failureThreshold
  • Defaults: 30s delay, 60s period, 30s timeout, 6 failures (more tolerant of NFS latency spikes)

loadbalancer.yaml

  • Adds {{- with .Values.load_balancer.annotations }} block for AWS NLB/ALB annotations
    (e.g. service.beta.kubernetes.io/aws-load-balancer-type: nlb)

Values Added

redis.affinity.enabled, redis.affinity.nodegroupKey, redis.affinity.nodegroupValues
redis.persistence.enabled  (default: true)
rserve.livenessProbe.initialDelaySeconds/periodSeconds/timeoutSeconds/failureThreshold
load_balancer.annotations: {}

…ning, LB annotations

- Add redis.persistence.enabled toggle; when false, use emptyDir instead
  of PVC (useful for ephemeral or dev deployments)
- Add redis.affinity.enabled toggle with configurable nodegroupKey and
  nodegroupValues (prevents pending pods when web-group label is absent)
- Make rserve liveness probe parameters configurable
  (initialDelaySeconds, periodSeconds, timeoutSeconds, failureThreshold)
  to tolerate transient NFS latency without unnecessary restarts
- Add load_balancer.annotations support for AWS NLB/ALB annotations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants