Fix OpenStudio not loading design day files with Solar Model Indicator of 'ASHRAETau2017' - #200
Open
eringold wants to merge 1 commit into
Open
Fix OpenStudio not loading design day files with Solar Model Indicator of 'ASHRAETau2017'#200eringold wants to merge 1 commit into
eringold wants to merge 1 commit into
Conversation
…r of 'ASHRAETau2017' for versions prior to 3.10. Before translating the DDY, the measure now checks the file contents for ASHRAETau2017. If found, it writes a sanitized copy (with ASHRAETau) into a fresh temp directory and translates that instead. The translation result is also now checked for emptiness and reports an error rather than raising on .get. Added test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… for versions prior to 3.10. Before translating the DDY, the measure now checks the file contents for ASHRAETau2017. If found, it writes a sanitized copy (with ASHRAETau) into a fresh temp directory and translates that instead. The translation result is also now checked for emptiness and reports an error rather than raising on .get. Added test.