Skip to content

Simplify dependencies for installation#347

Merged
martin-springer merged 7 commits into
developmentfrom
dependencies
Jun 26, 2026
Merged

Simplify dependencies for installation#347
martin-springer merged 7 commits into
developmentfrom
dependencies

Conversation

@RDaxini

@RDaxini RDaxini commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Describe your changes

Move pre-commit to dev build option
Moved several other packages to a geospatial build option
Attempted to create a geo extra, but most of those packages are imported at the module level, so the pytests can't run because pvdeg itself fails to import on a default install. It's only possible to move dask-jobqueue into geo because it’s imported inside a function in geospatial.py, so it isn’t triggered just by import pvdeg. That alone is not worth it and a major refactor to move all other imports to the function level is beyond the scope of this PR. This might be worth considering in future.

Issue ticket number and link

Fixes #341

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • Code changes are covered by tests.
  • Code changes have been evaluated for compatibility/integration with Scenario analysis (for future PRs)
  • Code changes have been evaluated for compatibility/integration with geospatial autotemplating (for future PRs)
  • New functions added to init.py
  • API.rst is up to date, along with other sphinx docs pages
  • Example notebooks are rerun and differences in results scrutinized
  • What's new changelog has been updated in the docs

@RDaxini RDaxini changed the title Dependencies Simplify dependencies for installation Jun 17, 2026
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.72%. Comparing base (51172fd) to head (46040c7).
⚠️ Report is 497 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #347      +/-   ##
===============================================
+ Coverage        71.66%   74.72%   +3.06%     
===============================================
  Files               40       41       +1     
  Lines             4524     4823     +299     
===============================================
+ Hits              3242     3604     +362     
+ Misses            1282     1219      -63     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RDaxini RDaxini added this to the v0.7.2 milestone Jun 17, 2026
@RDaxini RDaxini added the dependencies Pull requests that update a dependency file label Jun 17, 2026
@RDaxini
RDaxini marked this pull request as draft June 17, 2026 23:28
@RDaxini RDaxini changed the title Simplify dependencies for installation [WIP] Simplify dependencies for installation Jun 17, 2026
@RDaxini
RDaxini changed the base branch from main to development_0800 June 18, 2026 18:00
@RDaxini RDaxini changed the title [WIP] Simplify dependencies for installation Simplify dependencies for installation Jun 18, 2026
@RDaxini
RDaxini marked this pull request as ready for review June 18, 2026 18:00
@RDaxini
RDaxini changed the base branch from development_0800 to development June 18, 2026 18:00
@RDaxini
RDaxini requested a review from martin-springer June 18, 2026 18:00
@RDaxini

RDaxini commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator Author

nbval test failure is unrelated

@martin-springer
martin-springer merged commit 8a461fa into development Jun 26, 2026
17 of 18 checks passed
@martin-springer
martin-springer deleted the dependencies branch June 26, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JOSS] Installation dependencies

3 participants