Simplify dependencies for installation#347
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## development #347 +/- ##
===============================================
+ Coverage 71.66% 74.72% +3.06%
===============================================
Files 40 41 +1
Lines 4524 4823 +299
===============================================
+ Hits 3242 3604 +362
+ Misses 1282 1219 -63 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RDaxini
marked this pull request as draft
June 17, 2026 23:28
This reverts commit 7729818.
RDaxini
marked this pull request as ready for review
June 18, 2026 18:00
Collaborator
Author
|
nbval test failure is unrelated |
martin-springer
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move pre-commit to dev build option
Moved several other packages to a geospatial build optionAttempted to create a geo extra, but most of those packages are imported at the module level, so the pytests can't run because pvdeg itself fails to import on a default install. It's only possible to move dask-jobqueue into geo because it’s imported inside a function in geospatial.py, so it isn’t triggered just by import pvdeg. That alone is not worth it and a major refactor to move all other imports to the function level is beyond the scope of this PR. This might be worth considering in future.
Issue ticket number and link
Fixes #341
Type of change
Please delete options that are not relevant.
Checklist before requesting a review