Fix error if NumberofBedrooms=0 and NumberofBathrooms is omitted#2242
Open
shorowit wants to merge 4 commits into
Open
Fix error if NumberofBedrooms=0 and NumberofBathrooms is omitted#2242shorowit wants to merge 4 commits into
NumberofBedrooms=0 and NumberofBathrooms is omitted#2242shorowit wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates bathroom defaulting to ensure zero-bedroom homes remain schema-valid.
Changes:
- Enforces a minimum of one default bathroom.
- Adds zero-bedroom sample and regression coverage.
- Updates workflow documentation and changelog.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Changelog.md |
Records the bug fix. |
HPXMLtoOpenStudio/measure.xml |
Refreshes measure metadata and checksums. |
HPXMLtoOpenStudio/resources/defaults.rb |
Applies the minimum bathroom default. |
HPXMLtoOpenStudio/tests/test_defaults.rb |
Tests zero-bedroom defaulting. |
docs/source/workflow_inputs.rst |
Documents rounding and minimum behavior. |
workflow/hpxml_inputs.json |
Registers the regression sample. |
workflow/sample_files/base-enclosure-beds-0.xml |
Adds a zero-bedroom sample. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shorowit
marked this pull request as ready for review
July 17, 2026 22:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
NumberofBathroomswas being defaulted to zero, but the HPXML schema does not allow zero. We now set it to 1.I also proposed allowing zero in the schema here.
Checklist
Not all may apply:
EPvalidator.sch) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run