Skip to content

Unmet hours for dehumidification#2217

Open
shorowit wants to merge 15 commits into
masterfrom
dehumid_unmet_hours
Open

Unmet hours for dehumidification#2217
shorowit wants to merge 15 commits into
masterfrom
dehumid_unmet_hours

Conversation

@shorowit

@shorowit shorowit commented May 12, 2026

Copy link
Copy Markdown
Contributor

Pull Request Description

Closes #2203. Adds a dehumidification unmet hours output (tolerance = 1% RH) as well as a warning if the number of hours exceeds 300. If there are no dehumidifiers, zero will be reported.

Note: E+ with hourly timesteps does not perfectly maintain RH setpoint, rather we see oscillations that can result in reported unmet hours. Is this something we can address?

  • Note that the dehumidifier is the last piece of equipment that runs
  • Double-check our EMS program
  • Double-check sub-hourly timesteps
  • Do we see similar behavior if we add a dehumidifier to a standard E+ sample file?
  • Are there any E+ knobs/settings that would affect this?

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.sch) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

Comment thread HPXMLtoOpenStudio/resources/output.rb Outdated
shorowit and others added 3 commits May 21, 2026 14:37
…HPXML into dehumid_unmet_hours

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	ReportSimulationOutput/measure.xml
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit shorowit marked this pull request as ready for review May 21, 2026 22:04
@shorowit shorowit moved this from Triage to In progress in OpenStudio-HPXML May 22, 2026
@shorowit shorowit requested a review from Copilot May 28, 2026 18:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds annual/timeseries reporting support for dehumidification unmet hours, addressing #2203 by calculating hours where RH exceeds the dehumidifier setpoint tolerance and surfacing warnings for large values.

Changes:

  • Adds dehumidification unmet-hours EMS generation and reporting plumbing.
  • Adds dehumidifier availability EMS sensor support.
  • Updates constants, tests, measure metadata, README, docs, and changelog for the new output.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ReportSimulationOutput/tests/test_report_sim_output.rb Adds dehumidification unmet-hours columns to expected report outputs.
ReportSimulationOutput/README.md Documents the new measure output name.
ReportSimulationOutput/measure.xml Registers the new output and updates checksums/version metadata.
ReportSimulationOutput/measure.rb Wires dehumidification unmet hours into EMS output requests, annual reporting, and warnings.
HPXMLtoOpenStudio/resources/output.rb Adds EMS program for dehumidification unmet hours and renames/refactors unmet-hours program constants/variables.
HPXMLtoOpenStudio/resources/hvac.rb Adds an EMS sensor for dehumidifier availability schedules.
HPXMLtoOpenStudio/resources/constants.rb Adds dehumidification unmet-hours and availability constants.
HPXMLtoOpenStudio/measure.xml Updates resource checksums/version metadata.
docs/source/workflow_outputs.rst Documents dehumidification unmet-hours behavior and warning threshold.
Changelog.md Notes the new dehumidification unmet-hours feature.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread HPXMLtoOpenStudio/resources/output.rb
shorowit and others added 5 commits May 28, 2026 12:44
…HPXML into dehumid_unmet_hours

# Conflicts:
#	Changelog.md
#	HPXMLtoOpenStudio/measure.xml
#	workflow/tests/base_results/results_simulations_misc.csv
…HPXML into dehumid_unmet_hours

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
#	ReportSimulationOutput/measure.xml
#	workflow/tests/base_results/results_simulations_misc.csv
@shorowit

Copy link
Copy Markdown
Contributor Author

Filed an EnergyPlus issue: NatLabRockies/EnergyPlus#11657

@shorowit

shorowit commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Filed an EnergyPlus issue: NatLabRockies/EnergyPlus#11657

Check if somehow HR (instead of RH) is being controlled well in this test file.

@shorowit

shorowit commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Filed an EnergyPlus issue: NatLabRockies/EnergyPlus#11657

Check if somehow HR (instead of RH) is being controlled well in this test file.

Doesn't seem like HR is being controlled instead. Here's an oscillation in an example summer day. RH on the top axis, HR on the bottom axis.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Unmet hours for dehumidification

2 participants