Conversation
The 0.1.0 thumbnail was a filled gold trophy with a gradient, a specular highlight and a struck star. Too fussy for something only ever seen at 64px, and out of step with the lucide `Trophy` this plugin already puts on Studio's left rail. Replaced with line art: one ink tone on one ground, no gradients, no palette. Not the Steam logo, and not a silhouette of one. Valve's branding guidelines rule out both — their marks "may not be displayed as primary or prominent features on any non-Valve materials", the logo "must stand alone and may not be combined with any object", and only Valve's own artwork may be used, so a knocked-out variant is further out of bounds than the logo, not a safer middle ground. A plugin icon is the most prominent brand slot there is and this package is published by NarraLeaf. The plugin's *name* says Steam, which is ordinary descriptive use of the thing it integrates with. The generator now defines the drawing as strokes — segments and arcs — and inks the band within half a stroke of the nearest one. It used to rasterise a solid silhouette and derive an outline from it, which sounds equivalent and is not: every interior hole then has to be wider than the stroke or it fills in, and the handles did exactly that. Two new flags earn their keep: `--size=64` renders at the size a store row actually shows, which is the only size worth judging line art at, and `--stroke=` compares weights side by side. The icon is the only change; the plugin's code and its native bridge are untouched. A new version is needed regardless because `index.json` pins the thumbnail URL to the release tag, so 0.1.0's icon cannot be revised in place. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release merge for
narraleaf.steam-achievements@0.1.1. Icon only — the plugin's code and its native bridge are untouched.The 0.1.0 thumbnail was a filled gold trophy with a gradient, a specular highlight and a struck star. Too fussy for something only ever seen at 64px, and out of step with the lucide
Trophythis plugin already puts on Studio's left rail. It is line art now: one ink tone on one ground, thin uniform strokes, no gradients and no palette.Not the Steam logo, and not a silhouette of one. Valve's branding guidelines rule out both: their marks "may not be displayed as primary or prominent features on any non-Valve materials", the logo "must stand alone and may not be combined with any object", and only Valve's own artwork may be used — so a knocked-out variant is further out of bounds than the logo itself, not a safer middle ground. A plugin icon is the most prominent brand slot there is, and this package is published by NarraLeaf. The plugin's name says Steam, which is ordinary descriptive use of the thing it integrates with, and that is where the association belongs.
A new version is needed regardless of taste:
index.jsonpins the thumbnail URL to the release tag, so 0.1.0's icon cannot be revised in place.Generator
tools/make-icon.mjsnow defines the drawing as strokes — segments and arcs — and inks the band within half a stroke of the nearest one. It used to rasterise a solid silhouette and derive an outline from it, which sounds equivalent and is not: every interior hole then has to be wider than the stroke or it fills in, and the handles did exactly that. Two new flags:--size=64renders at the size a store row actually shows, and--stroke=compares weights side by side.Still zero dependencies — the PNG encoder is in the file, and nothing is read from the network or from any asset.
Checks
yarn typecheckclean, 29 tests pass,validate.mjs,generate-index.mjs --checkandpackage-plugin.mjsall green; the icon passes the registry's own square/size/format rules.Merge with a merge commit, not squash or rebase —
masteronly advances through release merges.🤖 Generated with Claude Code