fix: use getStateDiffJson instead of getStorageAccesses to avoid MemoryOOG - #1
Merged
Merged
Conversation
…ryOOG vm.getStorageAccesses() materializes all storage accesses into a Solidity memory array. On mainnet fork with many assets, this causes EvmError: MemoryOOG even with multi-GB memory limits. Replace with vm.parseJsonKeys on the already-available getStateDiffJson output, which checks for executor storage changes without allocating a massive array. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_validateNoExecutorStorageChange(introduced in Feat/storage diff aave-dao/aave-helpers#662) callsvm.getStorageAccesses()which materializes all storage accesses into a Solidity memory arrayEvmError: MemoryOOG— even with multi-GBmemory_limitvm.parseJsonKeys()on the already-availablegetStateDiffJson()output, which checks for executor storage changes without allocating a massive array into EVM memoryProtocolV3TestBaseandProtocolV2TestBaseTest plan
test_noExecutorStorageChange_passesstill passestest_executorStorageChange_revertsstill catches storage modificationsdefaultTestagainst AaveV3Ethereum (mainnet) — previously caused MemoryOOG, should now pass🤖 Generated with Claude Code