Fix architecture overview diagram accuracy#38
Conversation
- React/Vite not Next.js, Express 5 not Next.js API - Same-origin HTTP + WebSocket, not separate HTTPS - MongoDB connected from Auth Service (users, sessions) and Chat Service (conversations, messages, pending actions), not just LangChain - LLM provider shows both Gemini and Claude 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Architecture overview: Mermaid flowchart - Auth flow: Mermaid sequence diagram - Calendar viewing flow: Mermaid sequence diagram - Chat HITL flow: Mermaid sequence diagram - Production architecture: Mermaid flowchart - Conversation memory flow: kept as ASCII (multi-line box labels are more readable this way); fixed entry point from POST /api/chat to WS /ws 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Review FeedbackThis PR correctly updates the architecture diagram to match the actual implementation. I verified: ✅ Frontend stack: Confirmed React 19 + Vite + Tailwind (app/package.json:13-14,29) No bugs or security issues found. This is a clean documentation update that improves accuracy. |
PR Review - Fix architecture overview diagram accuracySummaryThis PR updates the system-design.md documentation to accurately reflect the current implementation, converting ASCII diagrams to Mermaid format and fixing several architectural inaccuracies. The changes are purely documentation improvements with no code modifications. Verified ClaimsI've verified the PR accurately corrects the following:
Documentation Quality ImprovementsPositive changes:
Issues FoundMinor issue in Architecture Overview diagram (system-design.md:25-26): The diagram shows AuthSvc connecting to MongoDB separately, but then the ChatSvc MongoDB node lists all collections including users and sessions which are also used by AuthSvc. This creates visual confusion about which service owns which collections. Recommendation: Either show a single MongoDB node with both services connecting to it (cleaner), or clarify which collections each service uses. Given that they share the same MongoDB instance (same connection string in app.ts and db.ts), a single shared MongoDB node would be more accurate. VerdictApproved with minor suggestion - The documentation accurately reflects the implementation and significantly improves diagram clarity. The MongoDB visualization issue is cosmetic and doesn't affect technical accuracy. Great work making the documentation match reality! |
🤖 Generated with Claude Code