Feat/search and reader retries - #29
Merged
Merged
Conversation
… improvements - Add fastlane metadata, screenshots, and store listing content - Add app icon source (1024px) and SVG logo to assets - Add screenshot tooling scripts (toola/) - Update release workflow: use stable Flutter channel, add build number from run_number, simplify signing validation - Ignore fastlane/report.xml and screenshots/ in gitignore Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avoids crash when production track has no releases yet. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rch, add reader fast-scanning retries
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves OPDS search compatibility by supporting OpenSearch description templates, adjusts the SQLite Flutter libs dependency to fix initialization issues, and adds resiliency around streaming reader image loads.
Changes:
- Added OpenSearch template fetching/parsing for catalogs whose
searchUrlis an OpenSearch descriptor, plus a newOpdsClient.fetchRawhelper. - Implemented retry + backoff when downloading streaming reader page images.
- Updated Android/network and release pipeline configuration (INTERNET permission, release workflow input), plus integration test overrides.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
pubspec.yaml |
Changes sqlite3_flutter_libs version used by the app. |
pubspec.lock |
Updates locked version/hash for sqlite3_flutter_libs. |
lib/features/reader/widgets/streaming_page_image.dart |
Adds retry/backoff around page image downloads and caching. |
lib/features/library/ui/comic_detail_sheet.dart |
Refactors publication info layout (removes thumbnail rendering). |
lib/features/library/providers/library_catalog_provider.dart |
Adds OpenSearch template fetch/parsing and updates URI template resolution behavior. |
lib/core/opds/opds_client.dart |
Adds fetchRaw for retrieving non-feed payloads with consistent status handling. |
integration_test/streaming_smoke_test.dart |
Adds downloads provider overrides to stabilize the smoke test. |
android/app/src/main/AndroidManifest.xml |
Adds INTERNET permission and enables cleartext traffic. |
.github/workflows/release.yml |
Adds configurable Play Store release_status input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
3
to
+7
| <application | ||
| android:label="ComicRow" | ||
| android:name="${applicationName}" | ||
| android:icon="@mipmap/ic_launcher"> | ||
| android:icon="@mipmap/ic_launcher" | ||
| android:usesCleartextTraffic="true"> |
Comment on lines
+14
to
+18
| release_status: | ||
| description: Google Play release status (completed, draft, halted, inProgress) | ||
| required: false | ||
| default: completed | ||
| type: string |
Comment on lines
+237
to
+241
| var template = searchUrl; | ||
| final rawUri = currentState.currentUri.resolve(searchUrl); | ||
|
|
||
| if (!searchUrl.contains('{searchTerms}') && !searchUrl.contains('{searchTerm}')) { | ||
| final fetchedTemplate = await _getSearchTemplate(rawUri); |
Comment on lines
+64
to
+69
| // Publication Info | ||
| Padding( | ||
| padding: const EdgeInsets.only(bottom: 16), | ||
| child: Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search was using openxml, and wasn't appropriately supported. we also resolved some problems with the sqlite initialization, where we were using the wrong dependency.