Skip to content

CI: actually run the Swift test suites (#440) #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nabzx merged 2 commits into from
Sep 26, 2026
Merged

CI: actually run the Swift test suites (#440) #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5da581d
CI: actually run the Swift test suites (#440)
Nabzx Sep 26, 2026
d263d4c
Fix two rung-1 fakes that never actually verified the readback (#440)
Nabzx Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,11 @@ jobs:
# suite. A PR could break dictationCoordinator.test.js and still
# merge on a green check, because the check never looked.
- run: npm test
# #440: hotkey-helper and accessibility-helper both have real Swift
# test suites, wired as .testTarget in their Package.swift, that no
# CI workflow or npm script ever invoked - a native-side regression
# could merge on a green check the same way #425's electron tests
# could. transcription-helper has no test target yet (needs FluidAudio
# mocked out first) and isn't built here either - still open.
- run: swift test --package-path native/hotkey-helper
- run: swift test --package-path native/accessibility-helper
6 changes: 4 additions & 2 deletions native/accessibility-helper/Tests/AccessibilityInjectionTests/InjectionEngineTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,8 @@ struct InjectionEngineTests {
// first read misses, but the tree comes good a beat later. Before
// #227 this dropped straight to blind-paste-or-hold.
let target = FakeAccessibilityTarget(
fieldInfo: FieldInfo(role: "AXTextField", valueChars: 10, selectedTextSettable: true)
fieldInfo: FieldInfo(role: "AXTextField", valueChars: 10, selectedTextSettable: true),
valueToReadBack: "hello"
)
let (engine, time, paster, _) = makeEngine(focusTarget: target, missesBeforeSuccess: 2)

Expand Down Expand Up @@ -379,7 +380,8 @@ struct InjectionEngineTests {
@Test func settleGuardPassesOnceTheTargetStabilizes() {
let time = SimulatedTime()
let target = FakeAccessibilityTarget(
fieldInfo: FieldInfo(role: "AXTextField", valueChars: 5, selectedTextSettable: true)
fieldInfo: FieldInfo(role: "AXTextField", valueChars: 5, selectedTextSettable: true),
valueToReadBack: "hello"
)
let paster = FakePaster(result: PasteResult(delivered: true, verified: false, note: ""))
let typer = FakeTyper()
Expand Down
Loading