feat(radio-materials): update ITU materials to version 4 - #70
Open
jeertmans wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
Since version 4 of recommendation ITU-R P.2040 has been released, a number of materials have been added or extended compared to version 3 (which was currently referenced in the docs). This PR updates the list of ITU materials and their frequency ranges to align with version 4.
Summary of changes:
clear_acrylic,vinyl_tile,carpet_tile,asphalt_concrete, andvacuum) and extended the existing frequency ranges up to 450 GHz insionna.rt.radio_materials.ituaccording to Table 3 of ITU-R P.2040-4.ITURadioMaterial.ITU_MATERIAL_COLORS(leaving existing material colors untouched). I tried to pick nice colors, but feel free to give you opinion on these ;-)rt.biband refreshed all citation references (:cite:p:) across the codebase and docs to refer to P.2040-4.itu-materials-table) that generates the materials table inradio_materials.rstdirectly fromITU_MATERIALS_PROPERTIESandITU_MATERIAL_COLORS. The table includes grouped headers matching the previous layout as well as inline color swatches. I believe this is much easier to have this table be automatically generated, rather than having to kept both the table and the Python files in sync.Let me know if you'd like any adjustments! :-)
See below for screenshots of Table 3 from the ITU recommendation.