Add radio map solver for terrain specified by a heightmap - #25
Open
Jklein64 wants to merge 11 commits into
Open
Conversation
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
There is a color issue with the preview where it is darker than expected, but this isn't solved by changing tone mapping or gamma correction parameters in pythreejs. Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Signed-off-by: Jason Klein <jklein.64@verizon.net>
Author
|
Here is a render of an example scene consisting of a gaussian bump with an offset measurement surface specified by a DEM:
And this is how it compares to running the same scene through a
This is the same scene and reshaping method used in the test. See this notebook for the visualization code. |
Collaborator
|
Hi @Jklein64 , Thank you for your contribution! We will review it carefully and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new subclass of
RadioMapcalledDemRadioMap, which is used to compute Radio Maps on Digital Elevation Models (DEMs, aka heightmaps). While some of this functionality could be mimicked withMeshRadioMap, we found it convenient to have a Radio Map class and helper functions that abstract away the resampling, triangulation, and rearrangement into a grid.This PR also adds a test case, modifies the visualization methods (render and preview) to support
DemRadioMapobjects, and updates Radio Map documentation.