Skip to content

Use cuda::std::bit_cast in stats minmax instead of hand-rolled helper #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 3 commits into from
Jul 29, 2026
Merged

Use cuda::std::bit_cast in stats minmax instead of hand-rolled helper #3095

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53f4df1
Use cuda::std::bit_cast in stats minmax instead of hand-rolled helper
says1117 Jul 28, 2026
a5d5f2c
Merge remote-tracking branch 'upstream/main' into use-cuda-std-bit-ca…
says1117 Jul 28, 2026
4ca058f
Include <cstdint> explicitly for std::int64_t in minmax
says1117 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions cpp/include/raft/stats/detail/minmax.cuh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION.
* SPDX-FileCopyrightText: Copyright (c) 2019-2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
* SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -9,22 +9,15 @@
#include <raft/util/cuda_utils.cuh>
#include <raft/util/cudart_utils.hpp>

#include <cuda/std/bit>

#include <cstdint>
#include <limits>

namespace raft {
namespace stats {
namespace detail {

// TODO: replace with `std::bitcast` once we adopt C++20 or libcu++ adds it
template <class To, class From>
constexpr To bit_cast(const From& from) noexcept
{
To to{};
static_assert(sizeof(To) == sizeof(From));
memcpy(&to, &from, sizeof(To));
return to;
}

template <typename T>
struct encode_traits {};

Expand All @@ -40,26 +33,26 @@ struct encode_traits<double> {

HDI int encode(float val)
{
int i = detail::bit_cast<int>(val);
int i = cuda::std::bit_cast<int>(val);
return i >= 0 ? i : (1 << 31) | ~i;
}

HDI long long encode(double val)
{
std::int64_t i = detail::bit_cast<std::int64_t>(val);
std::int64_t i = cuda::std::bit_cast<std::int64_t>(val);
return i >= 0 ? i : (1ULL << 63) | ~i;
}

HDI float decode(int val)
{
if (val < 0) val = (1 << 31) | ~val;
return detail::bit_cast<float>(val);
return cuda::std::bit_cast<float>(val);
}

HDI double decode(long long val)
{
if (val < 0) val = (1ULL << 63) | ~val;
return detail::bit_cast<double>(val);
return cuda::std::bit_cast<double>(val);
}

template <typename T, typename E>
Expand Down
Loading