Add logging filter to exclude per-task subprocess output from sflow.log#11
Merged
Merged
Conversation
- Introduced a new logging filter, `_DropTaskStreamFilter`, to prevent per-task subprocess output from being written to sflow.log, ensuring that only orchestration lines and command/status hints are logged. - Updated logging configuration to apply this filter to file handlers. - Enhanced the `SubprocessLauncher` to conditionally echo per-task output to the root logger based on whether the output is being streamed to an interactive console. - Added unit tests to verify the correct routing of per-task output and the functionality of the logging filter.
RogerLiu312
added a commit
that referenced
this pull request
Jul 22, 2026
Brings the v0.3.0 release line into main: Kubernetes backend (k8s / k8s_mpi), merge-pod same-node GPU fabrics, recursive deep-merge composition, declarative result parsing + S3 uploads, hardware monitoring, and richer run summaries. The logging-filter files (logging.py, core/launcher.py, cli/batch.py and their tests) conflicted because the main-only hotfix (#11: _DropTaskStreamFilter per-task log routing + venv bootstrap fix) was developed independently on both branches. Resolved by taking develop's version, which already incorporates that hotfix as a strict superset (every main-side test also present on develop). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_DropTaskStreamFilter, to prevent per-task subprocess output from being written to sflow.log, ensuring that only orchestration lines and command/status hints are logged.SubprocessLauncherto conditionally echo per-task output to the root logger based on whether the output is being streamed to an interactive console.